PUSHES REPORT: 13.0.7

This report shows who pushed the backports to the given release. This usually shows who did the backporting, testing, and review work.

Report generated: Wed Jun 01 05:06:07 CEST 2022

Distribution by priority

Count Priority
1 P1
9 P2
37 P3
36 P4
1 P5

Distribution by components

Count Component
84 100% Total
49 58.3% hotspot
20 23.8% hotspot/compiler
11 13.1% hotspot/runtime
8 9.5% hotspot/jvmti
4 4.8% hotspot/jfr
3 3.6% hotspot/svc-agent
2 2.4% hotspot/gc
1 1.2% hotspot
11 13.1% core-libs
2 2.4% core-libs/jdk.nashorn
2 2.4% core-libs/java.time
2 2.4% core-libs/java.lang
1 1.2% core-libs/java.net
1 1.2% core-libs
1 1.2% core-libs/javax.naming
1 1.2% core-libs/java.util:i18n
1 1.2% core-libs/java.nio
7 8.3% client-libs
4 4.8% client-libs/java.awt
1 1.2% client-libs/2d
1 1.2% client-libs/javax.swing
1 1.2% client-libs/javax.imageio
6 7.1% tools
3 3.6% tools/jshell
2 2.4% tools/javac
1 1.2% tools/javap
5 6.0% security-libs
4 4.8% security-libs/java.security
1 1.2% security-libs/javax.net.ssl
4 4.8% infrastructure
3 3.6% infrastructure/build
1 1.2% infrastructure
2 2.4% core-svc
2 2.4% core-svc/tools

Distribution by affiliation

This Release Pushes

Original Pushes

Count Committer
84 100% Total
80 95.2% Azul
39 46.4% Ekaterina Vergizova
16 19.0% Olga Mikhaltcova
14 16.7% Yuri Nesterenko
5 6.0% Ilarion Nakonechnyy
4 4.8% Sergey Nazarkin
1 1.2% Alexey Bakhtin
1 1.2% Dmitry Cherepanov
2 2.4% Independent
2 2.4% Attila Szegedi
1 1.2% JetBrains
1 1.2% Vladimir Kempik
1 1.2% Red Hat
1 1.2% Andrew Hughes
Count Committer
84 100% Total
50 59.5% Oracle
4 4.8% Coleen Phillimore
3 3.6% Tom Rodriguez
3 3.6% Rajan Halade
3 3.6% Poonam Bajaj Parhar
3 3.6% Tobias Hartmann
3 3.6% Alex Menkov
2 2.4% Markus Grönlund
2 2.4% Jan Lahoda
2 2.4% Leonid Mesnik
2 2.4% Harold Seigel
2 2.4% Daniil Titov
2 2.4% Vladimir Kozlov
2 2.4% Kiran Sidhartha Ravikumar
1 1.2% Sean Mullan
1 1.2% Erik Gahlin
1 1.2% Pankaj Bansal
1 1.2% Vicente Arturo Romero Zaldivar
1 1.2% Patrick Concannon
1 1.2% Prasanta Sadhukhan
1 1.2% Jayathirth D V
1 1.2% Jaikiran Pai
1 1.2% Jonathan Gibbons
1 1.2% Kevin Walls
1 1.2% Joe Darcy
1 1.2% Kim Barrett
1 1.2% Erik Österlund
1 1.2% Evan Whelan
1 1.2% Tim Bell
1 1.2% Erik Joelsson
1 1.2% Serguei Spitsyn
7 8.3% Red Hat
1 1.2% Elliott Baron
1 1.2% Aleksey Shipilev
1 1.2% Zhengyu Gu
1 1.2% Andrew Hughes
1 1.2% Severin Gehwolf
1 1.2% Roman Kennke
1 1.2% Roland Westrelin
5 6.0% Amazon
3 3.6% Sergey Bylokhov
1 1.2% Paul Hohensee
1 1.2% Dan Lutker
5 6.0% SAP
2 2.4% Thomas Stuefe
1 1.2% Goetz Lindenmaier
1 1.2% Christoph Langer
1 1.2% Matthias Baesken
4 4.8% Azul
2 2.4% Olga Mikhaltcova
1 1.2% Alexey Bakhtin
1 1.2% Yuri Nesterenko
3 3.6% ARM
2 2.4% Nick Gasson
1 1.2% Pengfei Li
3 3.6% NTT DATA
3 3.6% Yasumasa Suenaga
3 3.6% Tencent
2 2.4% Jie Fu
1 1.2% John Jiang
2 2.4% Independent
2 2.4% Attila Szegedi
1 1.2% DataDog
1 1.2% Jaroslav Bachorík
1 1.2% Huawei
1 1.2% Dong Bo

Chronological push log:

Days Ago This Release Push By Original Push By Bug Summary
Name Affiliation Name Affiliation
435 Olga Mikhaltcova Azul Olga Mikhaltcova Azul JDK-8263996 Fix build on 13u after JDK-8234779 backport
435 Olga Mikhaltcova Azul Kim Barrett Oracle JDK-8263961 Provide idiom for declaring classes noncopyable
435 Olga Mikhaltcova Azul John Jiang Tencent JDK-8263929 Further update javax/net/ssl/compatibility/Compatibility.java
438 Ilarion Nakonechnyy Azul Kevin Walls Oracle JDK-8263869 hs_err elapsed time in seconds is not accurate enough
438 Ilarion Nakonechnyy Azul Tobias Hartmann Oracle JDK-8263862 C2 compilation fails with "Live Node limit exceeded limit" during ConvI2L::Ideal optimization
438 Ekaterina Vergizova Azul Vicente Arturo Romero Zaldivar Oracle JDK-8263859 java.lang.ArrayIndexOutOfBoundsException thrown for malformed class file
438 Ekaterina Vergizova Azul Joe Darcy Oracle JDK-8263858 Double-rounding possibility in float fma
439 Ekaterina Vergizova Azul Pengfei Li ARM JDK-8263792 Fix incorrect result of Math.abs() with char type
439 Sergey Nazarkin Azul Nick Gasson ARM JDK-8263780 AArch64: two potential bugs in C1 LIRGenerator::generate_address()
440 Sergey Nazarkin Azul Dong Bo Huawei JDK-8263733 AArch64: Implement Base64.encodeBlock accelerator/intrinsic
441 Olga Mikhaltcova Azul Olga Mikhaltcova Azul JDK-8263647 Drag n Drop target area is wrong on high DPI systems
442 Ekaterina Vergizova Azul Thomas Stuefe SAP JDK-8263594 [windows] os::pd_map_memory error detection broken
445 Ekaterina Vergizova Azul Patrick Concannon Oracle JDK-8263520 (sc) SocketChannel.read/write throws AsynchronousCloseException on closed channel
445 Sergey Nazarkin Azul Nick Gasson ARM JDK-8263498 AArch64: C1 StubAssembler::call_RT can corrupt stack
445 Olga Mikhaltcova Azul Sergey Bylokhov Amazon JDK-8263494 [macOS] Deadlock in SunToolKit.realSync()
445 Sergey Nazarkin Azul Aleksey Shipilev Red Hat JDK-8263493 C1: 3-arg StubAssembler::call_RT stack-use condition is incorrect
452 Olga Mikhaltcova Azul Daniil Titov Oracle JDK-8263098 TestJstatdPort.java failed due to "ExportException: Port already in use:"
452 Attila Szegedi Independent Attila Szegedi Independent JDK-8263094 jdk/dynalink/TypeConverterFactoryMemoryLeakTest.java failed with "AssertionError: Should have GCd a method handle by now"
452 Ekaterina Vergizova Azul Harold Seigel Oracle JDK-8263081 TestUseContainerSupport.java fails on some Linux kernels w/o swap limit capabilities
453 Andrew Hughes Red Hat Andrew Hughes Red Hat JDK-8263046 x86 32-bit build fails when -fcf-protection is passed in the compiler flags
453 Dmitry Cherepanov Azul Kiran Sidhartha Ravikumar Oracle JDK-8263037 (tz) Upgrade time-zone data to tzdata2021a
453 Olga Mikhaltcova Azul Tim Bell Oracle JDK-8263034 Support compilers with multi-digit major version numbers
453 Attila Szegedi Independent Attila Szegedi Independent JDK-8263011 Dynalink leaks memory when generating type converters
454 Ekaterina Vergizova Azul Dan Lutker Amazon JDK-8262932 Update LogCompilation junit to 4.13.1
455 Ekaterina Vergizova Azul Markus Grönlund Oracle JDK-8262848 JFR fails with assertion: assert(t->unflushed_size() == 0) failed: invariant
455 Ekaterina Vergizova Azul Poonam Bajaj Parhar Oracle JDK-8262847 Regression introduced with JDK-8250984 - memory might be null in some machines
460 Ekaterina Vergizova Azul Erik Gahlin Oracle JDK-8262369 JFR: Can't handle constant dynamic used by Jacoco agent
460 Yuri Nesterenko Azul Sean Mullan Oracle JDK-8262078 Remove root certificates with 1024-bit keys
461 Alexey Bakhtin Azul Alexey Bakhtin Azul JDK-8262302 LDAP channel binding does not work with StartTLS extension
465 Olga Mikhaltcova Azul Tobias Hartmann Oracle JDK-8262076 Minimal fastdebug build broken after JDK-8245801
466 Olga Mikhaltcova Azul Tobias Hartmann Oracle JDK-8262038 StressRecompilation triggers assert "redundunt OSR recompilation detected. memory leak in CodeCache!"
466 Ekaterina Vergizova Azul Christoph Langer SAP JDK-8262012 Wrong package declarations in jline classes after JDK-8241598
473 Ekaterina Vergizova Azul Jan Lahoda Oracle JDK-8261664 Upgrade JLine to 3.14.0
473 Olga Mikhaltcova Azul Yasumasa Suenaga NTT DATA JDK-8261653 Can't start JVM when java home path includes non-ASCII character
473 Ekaterina Vergizova Azul Jan Lahoda Oracle JDK-8261641 Upgrade Jline to 3.12.1
473 Yuri Nesterenko Azul Rajan Halade Oracle JDK-8261639 Add SSL root certificates to Oracle Root CA program
473 Yuri Nesterenko Azul Rajan Halade Oracle JDK-8261635 Add Entrust root CA - G4 to Oracle Root CA program
474 Ekaterina Vergizova Azul Prasanta Sadhukhan Oracle JDK-8261602 Within native OOM error handling, assertions may hang the process
474 Ekaterina Vergizova Azul Leonid Mesnik Oracle JDK-8261592 WB_GetCodeBlob doesn't have ResourceMark
474 Ekaterina Vergizova Azul Coleen Phillimore Oracle JDK-8261591 graal crashes with Zombie.java test
474 Yuri Nesterenko Azul Pankaj Bansal Oracle JDK-8261586 [dark_mode ubuntu 20.04] The selected menu is not highlighted in GTKLookAndFeel
475 Ekaterina Vergizova Azul Erik Österlund Oracle JDK-8261517 Sweeper should keep current nmethod alive before yielding for ICStub refills
475 Yuri Nesterenko Azul Rajan Halade Oracle JDK-8261516 jdk jtreg test security/infra/java/security/cert/CertPathValidator/certification/GlobalSignR6CA.java fails
476 Ekaterina Vergizova Azul Severin Gehwolf Red Hat JDK-8261414 JTreg Failure: serviceability/sa/ClhsdbJstack.java causes NPE
476 Yuri Nesterenko Azul Kiran Sidhartha Ravikumar Oracle JDK-8261406 (tz) Upgrade time-zone data to tzdata2020f
477 Yuri Nesterenko Azul Sergey Bylokhov Amazon JDK-8261342 Toolkit#getScreenInsets() returns wrong value on HiDPI screens (Windows)
480 Yuri Nesterenko Azul Sergey Bylokhov Amazon JDK-8261241 Requested JDialog width is ignored
480 Ekaterina Vergizova Azul Daniil Titov Oracle JDK-8261240 GetClassMethods is confused by the presence of default methods in super interfaces
480 Olga Mikhaltcova Azul Harold Seigel Oracle JDK-8261222 runtime/CompressedOops/CompressedClassPointers.java fails with 'Narrow klass base: 0x0000000000000000' missing from stdout/stderr
480 Ekaterina Vergizova Azul Markus Grönlund Oracle JDK-8261214 SEGV in EdgeUtils::field_name_symbol(Edge const&)
481 Olga Mikhaltcova Azul Tom Rodriguez Oracle JDK-8261146 [JVMCI] add mark value to expose CodeOffsets::Frame_Complete
482 Ilarion Nakonechnyy Azul Alex Menkov Oracle JDK-8261078 LingeredApp doesn't log stdout/stderr if exits with non-zero code
482 Ilarion Nakonechnyy Azul Leonid Mesnik Oracle JDK-8261076 vmTestbase/gc/gctests/Steal/steal001/steal001.java fails with OOME
482 Ilarion Nakonechnyy Azul Paul Hohensee Amazon JDK-8261074 C1 emits an empty message when it inlines successfully
483 Ekaterina Vergizova Azul Goetz Lindenmaier SAP JDK-8260922 Fix build for windows 32-bit after 8212160 and 8234331.
484 Olga Mikhaltcova Azul Matthias Baesken SAP JDK-8260700 enhance os::pd_print_cpu_info on linux
484 Yuri Nesterenko Azul Yasumasa Suenaga NTT DATA JDK-8260699 JFrame::setVisible crashed with -Dfile.encoding=UTF-8 on Japanese Windows.
487 Ekaterina Vergizova Azul Serguei Spitsyn Oracle JDK-8260649 Minimal VM slowdebug build failed after JDK-8212160
487 Ekaterina Vergizova Azul Jie Fu Tencent JDK-8260648 Minimal VM is broken after JDK-8212160
487 Ekaterina Vergizova Azul Jayathirth D V Oracle JDK-8260645 GIF reader throws misleading exception with truncated images
487 Ekaterina Vergizova Azul Poonam Bajaj Parhar Oracle JDK-8260642 Improve diagnostic messages for class verification and redefinition failures
487 Ekaterina Vergizova Azul Elliott Baron Red Hat JDK-8260639 Annotation processing causes NPE during flow analysis
487 Ekaterina Vergizova Azul Coleen Phillimore Oracle JDK-8260638 JVMTI agent crashes with "assert(_value != 0LL) failed: resolving NULL _value"
488 Ekaterina Vergizova Azul Jonathan Gibbons Oracle JDK-8260590 change javap reporting on unknown attributes
488 Yuri Nesterenko Azul Jaikiran Pai Oracle JDK-8260588 Deadlock between URLStreamHandler.getHostAddress and file.Handler.openconnection
489 Ekaterina Vergizova Azul Poonam Bajaj Parhar Oracle JDK-8260521 ExceptionInInitializerError due to UncheckedIOException while initializing cgroupv1 subsystem
489 Yuri Nesterenko Azul Yasumasa Suenaga NTT DATA JDK-8260503 hsdis does not compile with binutils 2.34+
489 Ekaterina Vergizova Azul Evan Whelan Oracle JDK-8260500 Failed to launch JVM because of NullPointerException occured on System.props
490 Ekaterina Vergizova Azul Thomas Stuefe SAP JDK-8260434 NMT: jcmd VM.native_memory scale=1 crashes target VM
490 Olga Mikhaltcova Azul Vladimir Kozlov Oracle JDK-8260423 OopMapSet::all_do does oms.next() twice during iteration
491 Yuri Nesterenko Azul Roman Kennke Red Hat JDK-8260350 Don't use memset to initialize fields decode_env constructor in disassembler.cpp
491 Olga Mikhaltcova Azul Tom Rodriguez Oracle JDK-8260345 Minimal VM is broken after JDK-8231586
494 Olga Mikhaltcova Azul Tom Rodriguez Oracle JDK-8260305 enlarge encoding space for OopMapValue offsets
494 Yuri Nesterenko Azul Roland Westrelin Red Hat JDK-8260299 UseProfiledLoopPredicate fails with assert(_phase->get_loop(c) == loop) failed: have to be in the same loop
494 Ekaterina Vergizova Azul Coleen Phillimore Oracle JDK-8260002 JvmtiExport::post_class_unload() is broken for non-JavaThread initiators
496 Ekaterina Vergizova Azul Jaroslav Bachorík DataDog JDK-8260051 SIGILL in jdk.jfr.internal.PlatformRecorder.rotateDisk()
496 Vladimir Kempik JetBrains Erik Joelsson Oracle JDK-8260050 Missing -mmacosx-version-min=X flag when linking libjvm
496 Ekaterina Vergizova Azul Vladimir Kozlov Oracle JDK-8260047 AOT's Linker.java seems to eagerly fail-fast on Windows.
497 Ekaterina Vergizova Azul Jie Fu Tencent JDK-8259974 Minimal VM is broken after JDK-8173361
498 Ekaterina Vergizova Azul Alex Menkov Oracle JDK-8259921 SA might fail to attach to process with "Windbg Error: WaitForEvent failed"
498 Ekaterina Vergizova Azul Zhengyu Gu Red Hat JDK-8259919 Test runtime/NMT/HugeArenaTracking.java is failing on 32bit Windows
498 Ekaterina Vergizova Azul Coleen Phillimore Oracle JDK-8259918 various crashes in JvmtiExport::post_compiled_method_load
498 Ekaterina Vergizova Azul Alex Menkov Oracle JDK-8259899 Improve WindbgDebuggerLocal implementation
502 Yuri Nesterenko Azul Yuri Nesterenko Azul JDK-8259221 Bump update version for OpenJDK: jdk-13.0.7

No changesets log

Committer push log

Ilarion Nakonechnyy, Azul

Bug Summary
JDK-8261074 C1 emits an empty message when it inlines successfully
JDK-8263862 C2 compilation fails with "Live Node limit exceeded limit" during ConvI2L::Ideal optimization
JDK-8263869 hs_err elapsed time in seconds is not accurate enough
JDK-8261078 LingeredApp doesn't log stdout/stderr if exits with non-zero code
JDK-8261076 vmTestbase/gc/gctests/Steal/steal001/steal001.java fails with OOME

Alexey Bakhtin, Azul

Bug Summary
JDK-8262302 LDAP channel binding does not work with StartTLS extension

Andrew Hughes, Red Hat

Bug Summary
JDK-8263046 x86 32-bit build fails when -fcf-protection is passed in the compiler flags

Attila Szegedi, Independent

Bug Summary
JDK-8263011 Dynalink leaks memory when generating type converters
JDK-8263094 jdk/dynalink/TypeConverterFactoryMemoryLeakTest.java failed with "AssertionError: Should have GCd a method handle by now"

Dmitry Cherepanov, Azul

Bug Summary
JDK-8263037 (tz) Upgrade time-zone data to tzdata2021a

Ekaterina Vergizova, Azul

Bug Summary
JDK-8263520 (sc) SocketChannel.read/write throws AsynchronousCloseException on closed channel
JDK-8263594 [windows] os::pd_map_memory error detection broken
JDK-8260639 Annotation processing causes NPE during flow analysis
JDK-8260047 AOT's Linker.java seems to eagerly fail-fast on Windows.
JDK-8260590 change javap reporting on unknown attributes
JDK-8263858 Double-rounding possibility in float fma
JDK-8260521 ExceptionInInitializerError due to UncheckedIOException while initializing cgroupv1 subsystem
JDK-8260500 Failed to launch JVM because of NullPointerException occured on System.props
JDK-8260922 Fix build for windows 32-bit after 8212160 and 8234331.
JDK-8263792 Fix incorrect result of Math.abs() with char type
JDK-8261240 GetClassMethods is confused by the presence of default methods in super interfaces
JDK-8260645 GIF reader throws misleading exception with truncated images
JDK-8261591 graal crashes with Zombie.java test
JDK-8260642 Improve diagnostic messages for class verification and redefinition failures
JDK-8259899 Improve WindbgDebuggerLocal implementation
JDK-8263859 java.lang.ArrayIndexOutOfBoundsException thrown for malformed class file
JDK-8262848 JFR fails with assertion: assert(t->unflushed_size() == 0) failed: invariant
JDK-8262369 JFR: Can't handle constant dynamic used by Jacoco agent
JDK-8261414 JTreg Failure: serviceability/sa/ClhsdbJstack.java causes NPE
JDK-8260638 JVMTI agent crashes with "assert(_value != 0LL) failed: resolving NULL _value"
JDK-8260002 JvmtiExport::post_class_unload() is broken for non-JavaThread initiators
JDK-8259974 Minimal VM is broken after JDK-8173361
JDK-8260648 Minimal VM is broken after JDK-8212160
JDK-8260649 Minimal VM slowdebug build failed after JDK-8212160
JDK-8260434 NMT: jcmd VM.native_memory scale=1 crashes target VM
JDK-8262847 Regression introduced with JDK-8250984 - memory might be null in some machines
JDK-8259921 SA might fail to attach to process with "Windbg Error: WaitForEvent failed"
JDK-8261214 SEGV in EdgeUtils::field_name_symbol(Edge const&)
JDK-8260051 SIGILL in jdk.jfr.internal.PlatformRecorder.rotateDisk()
JDK-8261517 Sweeper should keep current nmethod alive before yielding for ICStub refills
JDK-8259919 Test runtime/NMT/HugeArenaTracking.java is failing on 32bit Windows
JDK-8263081 TestUseContainerSupport.java fails on some Linux kernels w/o swap limit capabilities
JDK-8262932 Update LogCompilation junit to 4.13.1
JDK-8261641 Upgrade Jline to 3.12.1
JDK-8261664 Upgrade JLine to 3.14.0
JDK-8259918 various crashes in JvmtiExport::post_compiled_method_load
JDK-8261592 WB_GetCodeBlob doesn't have ResourceMark
JDK-8261602 Within native OOM error handling, assertions may hang the process
JDK-8262012 Wrong package declarations in jline classes after JDK-8241598

Olga Mikhaltcova, Azul

Bug Summary
JDK-8261146 [JVMCI] add mark value to expose CodeOffsets::Frame_Complete
JDK-8263494 [macOS] Deadlock in SunToolKit.realSync()
JDK-8261653 Can't start JVM when java home path includes non-ASCII character
JDK-8263647 Drag n Drop target area is wrong on high DPI systems
JDK-8260700 enhance os::pd_print_cpu_info on linux
JDK-8260305 enlarge encoding space for OopMapValue offsets
JDK-8263996 Fix build on 13u after JDK-8234779 backport
JDK-8263929 Further update javax/net/ssl/compatibility/Compatibility.java
JDK-8262076 Minimal fastdebug build broken after JDK-8245801
JDK-8260345 Minimal VM is broken after JDK-8231586
JDK-8260423 OopMapSet::all_do does oms.next() twice during iteration
JDK-8263961 Provide idiom for declaring classes noncopyable
JDK-8261222 runtime/CompressedOops/CompressedClassPointers.java fails with 'Narrow klass base: 0x0000000000000000' missing from stdout/stderr
JDK-8262038 StressRecompilation triggers assert "redundunt OSR recompilation detected. memory leak in CodeCache!"
JDK-8263034 Support compilers with multi-digit major version numbers
JDK-8263098 TestJstatdPort.java failed due to "ExportException: Port already in use:"

Sergey Nazarkin, Azul

Bug Summary
JDK-8263498 AArch64: C1 StubAssembler::call_RT can corrupt stack
JDK-8263733 AArch64: Implement Base64.encodeBlock accelerator/intrinsic
JDK-8263780 AArch64: two potential bugs in C1 LIRGenerator::generate_address()
JDK-8263493 C1: 3-arg StubAssembler::call_RT stack-use condition is incorrect

Vladimir Kempik, JetBrains

Bug Summary
JDK-8260050 Missing -mmacosx-version-min=X flag when linking libjvm

Yuri Nesterenko, Azul

Bug Summary
JDK-8261406 (tz) Upgrade time-zone data to tzdata2020f
JDK-8261586 [dark_mode ubuntu 20.04] The selected menu is not highlighted in GTKLookAndFeel
JDK-8261635 Add Entrust root CA - G4 to Oracle Root CA program
JDK-8261639 Add SSL root certificates to Oracle Root CA program
JDK-8259221 Bump update version for OpenJDK: jdk-13.0.7
JDK-8260588 Deadlock between URLStreamHandler.getHostAddress and file.Handler.openconnection
JDK-8260350 Don't use memset to initialize fields decode_env constructor in disassembler.cpp
JDK-8260503 hsdis does not compile with binutils 2.34+
JDK-8261516 jdk jtreg test security/infra/java/security/cert/CertPathValidator/certification/GlobalSignR6CA.java fails
JDK-8260699 JFrame::setVisible crashed with -Dfile.encoding=UTF-8 on Japanese Windows.
JDK-8262078 Remove root certificates with 1024-bit keys
JDK-8261241 Requested JDialog width is ignored
JDK-8261342 Toolkit#getScreenInsets() returns wrong value on HiDPI screens (Windows)
JDK-8260299 UseProfiledLoopPredicate fails with assert(_phase->get_loop(c) == loop) failed: have to be in the same loop