1 /*
2 * Copyright (c) 2022, 2025, Oracle and/or its affiliates. All rights reserved.
3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
4 *
5 * This code is free software; you can redistribute it and/or modify it
6 * under the terms of the GNU General Public License version 2 only, as
7 * published by the Free Software Foundation.
8 *
9 * This code is distributed in the hope that it will be useful, but WITHOUT
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
12 * version 2 for more details (a copy is included in the LICENSE file that
13 * accompanied this code).
14 *
15 * You should have received a copy of the GNU General Public License version
16 * 2 along with this work; if not, write to the Free Software Foundation,
17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
18 *
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
20 * or visit www.oracle.com if you need additional information or have any
21 * questions.
22 *
23 */
24
25 #include "cds/aotClassInitializer.hpp"
26 #include "cds/archiveBuilder.hpp"
27 #include "cds/cdsHeapVerifier.hpp"
28 #include "classfile/classLoaderDataGraph.hpp"
29 #include "classfile/javaClasses.inline.hpp"
30 #include "classfile/moduleEntry.hpp"
31 #include "classfile/systemDictionaryShared.hpp"
32 #include "classfile/vmSymbols.hpp"
33 #include "logging/log.hpp"
34 #include "logging/logStream.hpp"
35 #include "memory/resourceArea.hpp"
36 #include "oops/fieldStreams.inline.hpp"
37 #include "oops/klass.inline.hpp"
38 #include "oops/oop.inline.hpp"
39 #include "runtime/fieldDescriptor.inline.hpp"
40
41 #if INCLUDE_CDS_JAVA_HEAP
42
43 // CDSHeapVerifier is used to check for problems where an archived object references a
44 // static field that may be get a different value at runtime. In the following example,
45 // Foo.get.test()
46 // correctly returns true when CDS disabled, but incorrectly returns false when CDS is enabled,
47 // because the archived archivedFoo.bar value is different than Bar.bar.
48 //
49 // class Foo {
50 // static final Foo archivedFoo; // this field is archived by CDS
51 // Bar bar;
52 // static {
53 // CDS.initializeFromArchive(Foo.class);
54 // if (archivedFoo == null) {
55 // archivedFoo = new Foo();
56 // archivedFoo.bar = Bar.bar;
57 // }
58 // }
59 // static Foo get() { return archivedFoo; }
60 // boolean test() {
61 // return bar == Bar.bar;
62 // }
63 // }
64 //
65 // class Bar {
66 // // this field is initialized in both CDS dump time and runtime.
67 // static final Bar bar = new Bar();
68 // }
69 //
70 // The check itself is simple:
71 // [1] CDSHeapVerifier::do_klass() collects all static fields
72 // [2] CDSHeapVerifier::do_entry() checks all the archived objects. None of them
73 // should be in [1]
74 //
75 // However, it's legal for *some* static fields to be referenced. The reasons are explained
76 // in the table of ADD_EXCL below.
77 //
78 // [A] In most of the cases, the module bootstrap code will update the static field
79 // to point to part of the archived module graph. E.g.,
80 // - java/lang/System::bootLayer
81 // - jdk/internal/loader/ClassLoaders::BOOT_LOADER
82 // [B] A final static String that's explicitly initialized inside <clinit>, but
83 // its value is deterministic and is always the same string literal.
84 // [C] A non-final static string that is assigned a string literal during class
85 // initialization; this string is never changed during -Xshare:dump.
86 // [D] Simple caches whose value doesn't matter.
87 // [E] Other cases (see comments in-line below).
88
89 CDSHeapVerifier::CDSHeapVerifier() : _archived_objs(0), _problems(0)
90 {
91 # define ADD_EXCL(...) { static const char* e[] = {__VA_ARGS__, nullptr}; add_exclusion(e); }
92
93 // Unfortunately this needs to be manually maintained. If
94 // test/hotspot/jtreg/runtime/cds/appcds/cacheObject/ArchivedEnumTest.java fails,
95 // you might need to fix the core library code, or fix the ADD_EXCL entries below.
96 //
97 // class field type
98 ADD_EXCL("java/lang/ClassLoader$Holder", "scl"); // A
99 ADD_EXCL("java/lang/Module", "ALL_UNNAMED_MODULE", // A
100 "ALL_UNNAMED_MODULE_SET", // A
101 "EVERYONE_MODULE", // A
102 "EVERYONE_SET"); // A
103
104 // This is the same as java/util/ImmutableCollections::EMPTY_SET, which is archived
105 ADD_EXCL("java/lang/reflect/AccessFlag$Location", "EMPTY_SET"); // E
106
107 ADD_EXCL("java/lang/System", "bootLayer"); // A
108
109 // A dummy object used by HashSet. The value doesn't matter and it's never
110 // tested for equality.
111 ADD_EXCL("java/util/HashSet", "PRESENT"); // E
112 ADD_EXCL("jdk/internal/loader/BuiltinClassLoader", "packageToModule"); // A
113 ADD_EXCL("jdk/internal/loader/ClassLoaders", "BOOT_LOADER", // A
114 "APP_LOADER", // A
115 "PLATFORM_LOADER"); // A
116 ADD_EXCL("jdk/internal/module/Builder", "cachedVersion"); // D
117 ADD_EXCL("jdk/internal/module/ModuleLoaderMap$Mapper", "APP_CLASSLOADER", // A
118 "APP_LOADER_INDEX", // A
119 "PLATFORM_CLASSLOADER", // A
120 "PLATFORM_LOADER_INDEX"); // A
121 ADD_EXCL("jdk/internal/module/ServicesCatalog", "CLV"); // A
122
123 // This just points to an empty Map
124 ADD_EXCL("jdk/internal/reflect/Reflection", "methodFilterMap"); // E
125
126 // Integer for 0 and 1 are in java/lang/Integer$IntegerCache and are archived
127 ADD_EXCL("sun/invoke/util/ValueConversions", "ONE_INT", // E
128 "ZERO_INT"); // E
129
130 if (CDSConfig::is_dumping_invokedynamic()) {
131 ADD_EXCL("java/lang/invoke/InvokerBytecodeGenerator", "MEMBERNAME_FACTORY", // D
132 "CD_Object_array", // E same as <...>ConstantUtils.CD_Object_array::CD_Object
133 "INVOKER_SUPER_DESC"); // E same as java.lang.constant.ConstantDescs::CD_Object
134 }
135
136 // These are used by BuiltinClassLoader::negativeLookupCache, etc but seem to be
137 // OK. TODO - we should completely disable the caching unless ArchiveLoaderLookupCache
138 // is enabled
139 ADD_EXCL("java/lang/Boolean", "TRUE", // E
140 "FALSE"); // E
141
142 # undef ADD_EXCL
143
144 ClassLoaderDataGraph::classes_do(this);
145 }
146
147 CDSHeapVerifier::~CDSHeapVerifier() {
148 if (_problems > 0) {
149 log_error(cds, heap)("Scanned %d objects. Found %d case(s) where "
150 "an object points to a static field that "
151 "may hold a different value at runtime.", _archived_objs, _problems);
152 //MetaspaceShared::unrecoverable_writing_error(); // FIXME -- leyden+JEP483 merge
153 }
154 }
155
156 class CDSHeapVerifier::CheckStaticFields : public FieldClosure {
157 CDSHeapVerifier* _verifier;
158 InstanceKlass* _ik; // The class whose static fields are being checked.
159 const char** _exclusions;
160 public:
161 CheckStaticFields(CDSHeapVerifier* verifier, InstanceKlass* ik)
162 : _verifier(verifier), _ik(ik) {
163 _exclusions = _verifier->find_exclusion(_ik);
164 }
165
166 void do_field(fieldDescriptor* fd) {
167 if (fd->field_type() != T_OBJECT) {
168 return;
169 }
170
171 if (fd->signature()->equals("Ljdk/internal/access/JavaLangAccess;")) {
172 // A few classes have static fields that point to SharedSecrets.getJavaLangAccess().
173 // This object carries no state and we can create a new one in the production run.
174 return;
175 }
176 oop static_obj_field = _ik->java_mirror()->obj_field(fd->offset());
177 if (static_obj_field != nullptr) {
178 Klass* field_type = static_obj_field->klass();
179 if (_exclusions != nullptr) {
180 for (const char** p = _exclusions; *p != nullptr; p++) {
181 if (fd->name()->equals(*p)) {
182 return;
183 }
184 }
185 }
186
187 if (fd->is_final() && java_lang_String::is_instance(static_obj_field) && fd->has_initial_value()) {
188 // This field looks like like this in the Java source:
189 // static final SOME_STRING = "a string literal";
190 // This string literal has been stored in the shared string table, so it's OK
191 // for the archived objects to refer to it.
192 return;
193 }
194 if (fd->is_final() && java_lang_Class::is_instance(static_obj_field)) {
195 // This field points to an archived mirror.
196 return;
197 }
198
199 if (field_type->is_instance_klass()) {
200 InstanceKlass* field_ik = InstanceKlass::cast(field_type);
201 if (field_ik->is_enum_subclass()) {
202 if (field_ik->has_archived_enum_objs() || ArchiveUtils::has_aot_initialized_mirror(field_ik)) {
203 // This field is an Enum. If any instance of this Enum has been archived, we will archive
204 // all static fields of this Enum as well.
205 return;
206 }
207 }
208
209 if (field_ik->is_hidden() && ArchiveUtils::has_aot_initialized_mirror(field_ik)) {
210 // We have a static field in a core-library class that points to a method reference, which
211 // are safe to archive.
212 guarantee(_ik->module()->name() == vmSymbols::java_base(), "sanity");
213 return;
214 }
215
216 if (field_ik == vmClasses::MethodType_klass()) {
217 // The identity of MethodTypes are preserved between assembly phase and production runs
218 // (by MethodType::AOTHolder::archivedMethodTypes). No need to check.
219 return;
220 }
221
222 if (field_ik == vmClasses::internal_Unsafe_klass() && ArchiveUtils::has_aot_initialized_mirror(field_ik)) {
223 // There's only a single instance of jdk/internal/misc/Unsafe, so all references will
224 // be pointing to this singleton, which has been archived.
225 return;
226 }
227 }
228
229 // This field *may* be initialized to a different value at runtime. Remember it
230 // and check later if it appears in the archived object graph.
231 _verifier->add_static_obj_field(_ik, static_obj_field, fd->name());
232 }
233 }
234 };
235
236 // Remember all the static object fields of every class that are currently
237 // loaded. Later, we will check if any archived objects reference one of
238 // these fields.
239 void CDSHeapVerifier::do_klass(Klass* k) {
240 if (k->is_instance_klass()) {
241 InstanceKlass* ik = InstanceKlass::cast(k);
242
243 if (HeapShared::is_subgraph_root_class(ik)) {
244 // ik is inside one of the ArchivableStaticFieldInfo tables
245 // in heapShared.cpp. We assume such classes are programmed to
246 // update their static fields correctly at runtime.
247 return;
248 }
249
250 if (ArchiveUtils::has_aot_initialized_mirror(ik)) {
251 // ik's <clinit> won't be executed at runtime, the static fields in
252 // ik will carry their values to runtime.
253 return;
254 }
255
256 CheckStaticFields csf(this, ik);
257 ik->do_local_static_fields(&csf);
258 }
259 }
260
261 void CDSHeapVerifier::add_static_obj_field(InstanceKlass* ik, oop field, Symbol* name) {
262 StaticFieldInfo info = {ik, name};
263 _table.put(field, info);
264 }
265
266 // This function is called once for every archived heap object. Warn if this object is referenced by
267 // a static field of a class that's not aot-initialized.
268 inline bool CDSHeapVerifier::do_entry(oop& orig_obj, HeapShared::CachedOopInfo& value) {
269 _archived_objs++;
270
271 if (java_lang_String::is_instance(orig_obj) && HeapShared::is_dumped_interned_string(orig_obj)) {
272 // It's quite often for static fields to have interned strings. These are most likely not
273 // problematic (and are hard to filter). So we will ignore them.
274 return true; /* keep on iterating */
275 }
276
277 StaticFieldInfo* info = _table.get(orig_obj);
278 if (info != nullptr) {
279 ResourceMark rm;
280 char* class_name = info->_holder->name()->as_C_string();
281 char* field_name = info->_name->as_C_string();
282 LogStream ls(Log(cds, heap)::warning());
283 ls.print_cr("Archive heap points to a static field that may hold a different value at runtime:");
284 ls.print_cr("Field: %s::%s", class_name, field_name);
285 ls.print("Value: ");
286 orig_obj->print_on(&ls);
287 ls.print_cr("--- trace begin ---");
288 trace_to_root(&ls, orig_obj, nullptr, &value);
289 ls.print_cr("--- trace end ---");
290 ls.cr();
291 _problems ++;
292 }
293
294 return true; /* keep on iterating */
295 }
296
297 class CDSHeapVerifier::TraceFields : public FieldClosure {
298 oop _orig_obj;
299 oop _orig_field;
300 outputStream* _st;
301
302 public:
303 TraceFields(oop orig_obj, oop orig_field, outputStream* st)
304 : _orig_obj(orig_obj), _orig_field(orig_field), _st(st) {}
305
306 void do_field(fieldDescriptor* fd) {
307 if (fd->field_type() == T_OBJECT || fd->field_type() == T_ARRAY) {
308 oop obj_field = _orig_obj->obj_field(fd->offset());
309 if (obj_field == _orig_field) {
310 _st->print("::%s (offset = %d)", fd->name()->as_C_string(), fd->offset());
311 }
312 }
313 }
314 };
315
316 // Call this function (from gdb, etc) if you want to know why an object is archived.
317 void CDSHeapVerifier::trace_to_root(outputStream* st, oop orig_obj) {
318 HeapShared::CachedOopInfo* info = HeapShared::archived_object_cache()->get(orig_obj);
319 if (info != nullptr) {
320 trace_to_root(st, orig_obj, nullptr, info);
321 } else {
322 st->print_cr("Not an archived object??");
323 }
324 }
325
326 const char* static_field_name(oop mirror, oop field) {
327 Klass* k = java_lang_Class::as_Klass(mirror);
328 if (k->is_instance_klass()) {
329 for (JavaFieldStream fs(InstanceKlass::cast(k)); !fs.done(); fs.next()) {
330 if (fs.access_flags().is_static()) {
331 fieldDescriptor& fd = fs.field_descriptor();
332 switch (fd.field_type()) {
333 case T_OBJECT:
334 case T_ARRAY:
335 if (mirror->obj_field(fd.offset()) == field) {
336 return fs.name()->as_C_string();
337 }
338 break;
339 default:
340 break;
341 }
342 }
343 }
344 }
345
346 return "<unknown>";
347 }
348
349 int CDSHeapVerifier::trace_to_root(outputStream* st, oop orig_obj, oop orig_field, HeapShared::CachedOopInfo* info) {
350 int level = 0;
351 if (info->orig_referrer() != nullptr) {
352 HeapShared::CachedOopInfo* ref = HeapShared::archived_object_cache()->get(info->orig_referrer());
353 assert(ref != nullptr, "sanity");
354 level = trace_to_root(st, info->orig_referrer(), orig_obj, ref) + 1;
355 } else if (java_lang_String::is_instance(orig_obj)) {
356 st->print_cr("[%2d] (shared string table)", level++);
357 }
358 Klass* k = orig_obj->klass();
359 ResourceMark rm;
360 st->print("[%2d] ", level);
361 orig_obj->print_address_on(st);
362 st->print(" %s", k->internal_name());
363 if (java_lang_Class::is_instance(orig_obj)) {
364 st->print(" (%s::%s)", java_lang_Class::as_Klass(orig_obj)->external_name(), static_field_name(orig_obj, orig_field));
365 }
366 if (orig_field != nullptr) {
367 if (k->is_instance_klass()) {
368 TraceFields clo(orig_obj, orig_field, st);
369 InstanceKlass::cast(k)->do_nonstatic_fields(&clo);
370 } else {
371 assert(orig_obj->is_objArray(), "must be");
372 objArrayOop array = (objArrayOop)orig_obj;
373 for (int i = 0; i < array->length(); i++) {
374 if (array->obj_at(i) == orig_field) {
375 st->print(" @[%d]", i);
376 break;
377 }
378 }
379 }
380 }
381 st->cr();
382
383 return level;
384 }
385
386 void CDSHeapVerifier::verify() {
387 CDSHeapVerifier verf;
388 HeapShared::archived_object_cache()->iterate(&verf);
389 }
390
391 #endif // INCLUDE_CDS_JAVA_HEAP