1 /*
2 * Copyright (c) 2022, 2025, Oracle and/or its affiliates. All rights reserved.
3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
4 *
5 * This code is free software; you can redistribute it and/or modify it
6 * under the terms of the GNU General Public License version 2 only, as
7 * published by the Free Software Foundation.
8 *
9 * This code is distributed in the hope that it will be useful, but WITHOUT
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
12 * version 2 for more details (a copy is included in the LICENSE file that
13 * accompanied this code).
14 *
15 * You should have received a copy of the GNU General Public License version
16 * 2 along with this work; if not, write to the Free Software Foundation,
17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
18 *
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
20 * or visit www.oracle.com if you need additional information or have any
21 * questions.
22 *
23 */
24
25 #include "cds/aotClassInitializer.hpp"
26 #include "cds/archiveBuilder.hpp"
27 #include "cds/cdsHeapVerifier.hpp"
28 #include "classfile/classLoaderDataGraph.hpp"
29 #include "classfile/javaClasses.inline.hpp"
30 #include "classfile/moduleEntry.hpp"
31 #include "classfile/systemDictionaryShared.hpp"
32 #include "classfile/vmSymbols.hpp"
33 #include "logging/log.hpp"
34 #include "logging/logStream.hpp"
35 #include "memory/resourceArea.hpp"
36 #include "oops/fieldStreams.inline.hpp"
37 #include "oops/klass.inline.hpp"
38 #include "oops/oop.inline.hpp"
39 #include "runtime/fieldDescriptor.inline.hpp"
40
41 #if INCLUDE_CDS_JAVA_HEAP
42
43 // CDSHeapVerifier is used to check for problems where an archived object references a
44 // static field that may be get a different value at runtime.
45 //
46 // *Please see comments in aotClassInitializer.cpp for how to avoid such problems*,
47 //
48 // In the following example,
49 // Foo.get.test()
50 // correctly returns true when CDS disabled, but incorrectly returns false when CDS is enabled,
51 // because the archived archivedFoo.bar value is different than Bar.bar.
52 //
53 // class Foo {
54 // static final Foo archivedFoo; // this field is archived by CDS
55 // Bar bar;
56 // static {
57 // CDS.initializeFromArchive(Foo.class);
58 // if (archivedFoo == null) {
59 // archivedFoo = new Foo();
60 // archivedFoo.bar = Bar.bar;
61 // }
62 // }
63 // static Foo get() { return archivedFoo; }
64 // boolean test() {
65 // return bar == Bar.bar;
66 // }
67 // }
68 //
69 // class Bar {
70 // // this field is initialized in both CDS dump time and runtime.
71 // static final Bar bar = new Bar();
72 // }
73 //
74 // The check itself is simple:
75 // [1] CDSHeapVerifier::do_klass() collects all static fields
76 // [2] CDSHeapVerifier::do_entry() checks all the archived objects. None of them
77 // should be in [1]
78 //
79 // However, it's legal for *some* static fields to be referenced. The reasons are explained
80 // in the table of ADD_EXCL below.
81 //
82 // [A] In most of the cases, the module bootstrap code will update the static field
83 // to point to part of the archived module graph. E.g.,
84 // - java/lang/System::bootLayer
85 // - jdk/internal/loader/ClassLoaders::BOOT_LOADER
86 // [B] A final static String that's explicitly initialized inside <clinit>, but
87 // its value is deterministic and is always the same string literal.
88 // [C] A non-final static string that is assigned a string literal during class
89 // initialization; this string is never changed during -Xshare:dump.
90 // [D] Simple caches whose value doesn't matter.
91 // [E] Other cases (see comments in-line below).
92
93 CDSHeapVerifier::CDSHeapVerifier() : _archived_objs(0), _problems(0)
94 {
95 # define ADD_EXCL(...) { static const char* e[] = {__VA_ARGS__, nullptr}; add_exclusion(e); }
96
97 // Unfortunately this needs to be manually maintained. If
98 // test/hotspot/jtreg/runtime/cds/appcds/cacheObject/ArchivedEnumTest.java fails,
99 // you might need to fix the core library code, or fix the ADD_EXCL entries below.
100 //
101 // class field type
102 ADD_EXCL("java/lang/ClassLoader$Holder", "scl"); // A
103 ADD_EXCL("java/lang/Module", "ALL_UNNAMED_MODULE", // A
104 "ALL_UNNAMED_MODULE_SET", // A
105 "EVERYONE_MODULE", // A
106 "EVERYONE_SET"); // A
107
108 // This is the same as java/util/ImmutableCollections::EMPTY_SET, which is archived
109 ADD_EXCL("java/lang/reflect/AccessFlag$Location", "EMPTY_SET"); // E
110
111 ADD_EXCL("java/lang/System", "bootLayer"); // A
112
113 ADD_EXCL("java/util/Collections", "EMPTY_LIST"); // E
114
115 // A dummy object used by HashSet. The value doesn't matter and it's never
116 // tested for equality.
117 ADD_EXCL("java/util/HashSet", "PRESENT"); // E
118 ADD_EXCL("jdk/internal/loader/BuiltinClassLoader", "packageToModule"); // A
119 ADD_EXCL("jdk/internal/loader/ClassLoaders", "BOOT_LOADER", // A
120 "APP_LOADER", // A
121 "PLATFORM_LOADER"); // A
122 ADD_EXCL("jdk/internal/module/Builder", "cachedVersion"); // D
123 ADD_EXCL("jdk/internal/module/ModuleLoaderMap$Mapper", "APP_CLASSLOADER", // A
124 "APP_LOADER_INDEX", // A
125 "PLATFORM_CLASSLOADER", // A
126 "PLATFORM_LOADER_INDEX"); // A
127 ADD_EXCL("jdk/internal/module/ServicesCatalog", "CLV"); // A
128
129 // This just points to an empty Map
130 ADD_EXCL("jdk/internal/reflect/Reflection", "methodFilterMap"); // E
131
132 // Integer for 0 and 1 are in java/lang/Integer$IntegerCache and are archived
133 ADD_EXCL("sun/invoke/util/ValueConversions", "ONE_INT", // E
134 "ZERO_INT"); // E
135
136 if (CDSConfig::is_dumping_method_handles()) {
137 ADD_EXCL("java/lang/invoke/InvokerBytecodeGenerator", "MEMBERNAME_FACTORY", // D
138 "CD_Object_array", // E same as <...>ConstantUtils.CD_Object_array::CD_Object
139 "INVOKER_SUPER_DESC"); // E same as java.lang.constant.ConstantDescs::CD_Object
140
141 ADD_EXCL("java/lang/runtime/ObjectMethods", "CLASS_IS_INSTANCE", // D
142 "FALSE", // D
143 "TRUE", // D
144 "ZERO"); // D
145 }
146
147 if (CDSConfig::is_dumping_packages()) {
148 ADD_EXCL("java/lang/Package$VersionInfo", "NULL_VERSION_INFO"); // D
149 }
150
151 // These are used by BuiltinClassLoader::negativeLookupCache, etc but seem to be
152 // OK. TODO - we should completely disable the caching unless ArchiveLoaderLookupCache
153 // is enabled
154 ADD_EXCL("java/lang/Boolean", "TRUE", // E
155 "FALSE"); // E
156
157 # undef ADD_EXCL
158
159 ClassLoaderDataGraph::classes_do(this);
160 }
161
162 CDSHeapVerifier::~CDSHeapVerifier() {
163 if (_problems > 0) {
164 log_error(aot, heap)("Scanned %d objects. Found %d case(s) where "
165 "an object points to a static field that "
166 "may hold a different value at runtime.", _archived_objs, _problems);
167 log_error(aot, heap)("Please see cdsHeapVerifier.cpp and aotClassInitializer.cpp for details");
168 //MetaspaceShared::unrecoverable_writing_error(); // FIXME -- leyden+JEP483 merge
169 }
170 }
171
172 class CDSHeapVerifier::CheckStaticFields : public FieldClosure {
173 CDSHeapVerifier* _verifier;
174 InstanceKlass* _ik; // The class whose static fields are being checked.
175 const char** _exclusions;
176 public:
177 CheckStaticFields(CDSHeapVerifier* verifier, InstanceKlass* ik)
178 : _verifier(verifier), _ik(ik) {
179 _exclusions = _verifier->find_exclusion(_ik);
180 }
181
182 void do_field(fieldDescriptor* fd) {
183 if (fd->field_type() != T_OBJECT) {
184 return;
185 }
186
187 if (fd->signature()->equals("Ljdk/internal/access/JavaLangAccess;")) {
188 // A few classes have static fields that point to SharedSecrets.getJavaLangAccess().
189 // This object carries no state and we can create a new one in the production run.
190 return;
191 }
192 oop static_obj_field = _ik->java_mirror()->obj_field(fd->offset());
193 if (static_obj_field != nullptr) {
194 Klass* field_type = static_obj_field->klass();
195 if (_exclusions != nullptr) {
196 for (const char** p = _exclusions; *p != nullptr; p++) {
197 if (fd->name()->equals(*p)) {
198 return;
199 }
200 }
201 }
202
203 if (fd->is_final() && java_lang_String::is_instance(static_obj_field) && fd->has_initial_value()) {
204 // This field looks like like this in the Java source:
205 // static final SOME_STRING = "a string literal";
206 // This string literal has been stored in the shared string table, so it's OK
207 // for the archived objects to refer to it.
208 return;
209 }
210 if (fd->is_final() && java_lang_Class::is_instance(static_obj_field)) {
211 // This field points to an archived mirror.
212 return;
213 }
214
215 if (field_type->is_instance_klass()) {
216 InstanceKlass* field_ik = InstanceKlass::cast(field_type);
217 if (field_ik->is_enum_subclass()) {
218 if (field_ik->has_archived_enum_objs() || ArchiveUtils::has_aot_initialized_mirror(field_ik)) {
219 // This field is an Enum. If any instance of this Enum has been archived, we will archive
220 // all static fields of this Enum as well.
221 return;
222 }
223 }
224
225 if (field_ik->is_hidden() && ArchiveUtils::has_aot_initialized_mirror(field_ik)) {
226 // We have a static field in a core-library class that points to a method reference, which
227 // are safe to archive.
228 guarantee(_ik->module()->name() == vmSymbols::java_base(), "sanity");
229 return;
230 }
231
232 if (field_ik == vmClasses::MethodType_klass()) {
233 // The identity of MethodTypes are preserved between assembly phase and production runs
234 // (by MethodType::AOTHolder::archivedMethodTypes). No need to check.
235 return;
236 }
237
238 if (field_ik == vmClasses::internal_Unsafe_klass() && ArchiveUtils::has_aot_initialized_mirror(field_ik)) {
239 // There's only a single instance of jdk/internal/misc/Unsafe, so all references will
240 // be pointing to this singleton, which has been archived.
241 return;
242 }
243 }
244
245 // This field *may* be initialized to a different value at runtime. Remember it
246 // and check later if it appears in the archived object graph.
247 _verifier->add_static_obj_field(_ik, static_obj_field, fd->name());
248 }
249 }
250 };
251
252 // Remember all the static object fields of every class that are currently
253 // loaded. Later, we will check if any archived objects reference one of
254 // these fields.
255 void CDSHeapVerifier::do_klass(Klass* k) {
256 if (k->is_instance_klass()) {
257 InstanceKlass* ik = InstanceKlass::cast(k);
258
259 if (HeapShared::is_subgraph_root_class(ik)) {
260 // ik is inside one of the ArchivableStaticFieldInfo tables
261 // in heapShared.cpp. We assume such classes are programmed to
262 // update their static fields correctly at runtime.
263 return;
264 }
265
266 if (ArchiveUtils::has_aot_initialized_mirror(ik)) {
267 // ik's <clinit> won't be executed at runtime, the static fields in
268 // ik will carry their values to runtime.
269 return;
270 }
271
272 CheckStaticFields csf(this, ik);
273 ik->do_local_static_fields(&csf);
274 }
275 }
276
277 void CDSHeapVerifier::add_static_obj_field(InstanceKlass* ik, oop field, Symbol* name) {
278 StaticFieldInfo info = {ik, name};
279 _table.put(field, info);
280 }
281
282 // This function is called once for every archived heap object. Warn if this object is referenced by
283 // a static field of a class that's not aot-initialized.
284 inline bool CDSHeapVerifier::do_entry(oop& orig_obj, HeapShared::CachedOopInfo& value) {
285 _archived_objs++;
286
287 if (java_lang_String::is_instance(orig_obj) && HeapShared::is_dumped_interned_string(orig_obj)) {
288 // It's quite often for static fields to have interned strings. These are most likely not
289 // problematic (and are hard to filter). So we will ignore them.
290 return true; /* keep on iterating */
291 }
292
293 StaticFieldInfo* info = _table.get(orig_obj);
294 if (info != nullptr) {
295 ResourceMark rm;
296 char* class_name = info->_holder->name()->as_C_string();
297 char* field_name = info->_name->as_C_string();
298 LogStream ls(Log(aot, heap)::warning());
299 ls.print_cr("Archive heap points to a static field that may hold a different value at runtime:");
300 ls.print_cr("Field: %s::%s", class_name, field_name);
301 ls.print("Value: ");
302 orig_obj->print_on(&ls);
303 ls.print_cr("--- trace begin ---");
304 trace_to_root(&ls, orig_obj, nullptr, &value);
305 ls.print_cr("--- trace end ---");
306 ls.cr();
307 _problems ++;
308 }
309
310 return true; /* keep on iterating */
311 }
312
313 class CDSHeapVerifier::TraceFields : public FieldClosure {
314 oop _orig_obj;
315 oop _orig_field;
316 outputStream* _st;
317
318 public:
319 TraceFields(oop orig_obj, oop orig_field, outputStream* st)
320 : _orig_obj(orig_obj), _orig_field(orig_field), _st(st) {}
321
322 void do_field(fieldDescriptor* fd) {
323 if (fd->field_type() == T_OBJECT || fd->field_type() == T_ARRAY) {
324 oop obj_field = _orig_obj->obj_field(fd->offset());
325 if (obj_field == _orig_field) {
326 _st->print("::%s (offset = %d)", fd->name()->as_C_string(), fd->offset());
327 }
328 }
329 }
330 };
331
332 // Call this function (from gdb, etc) if you want to know why an object is archived.
333 void CDSHeapVerifier::trace_to_root(outputStream* st, oop orig_obj) {
334 HeapShared::CachedOopInfo* info = HeapShared::archived_object_cache()->get(orig_obj);
335 if (info != nullptr) {
336 trace_to_root(st, orig_obj, nullptr, info);
337 } else {
338 st->print_cr("Not an archived object??");
339 }
340 }
341
342 const char* static_field_name(oop mirror, oop field) {
343 Klass* k = java_lang_Class::as_Klass(mirror);
344 if (k->is_instance_klass()) {
345 for (JavaFieldStream fs(InstanceKlass::cast(k)); !fs.done(); fs.next()) {
346 if (fs.access_flags().is_static()) {
347 fieldDescriptor& fd = fs.field_descriptor();
348 switch (fd.field_type()) {
349 case T_OBJECT:
350 case T_ARRAY:
351 if (mirror->obj_field(fd.offset()) == field) {
352 return fs.name()->as_C_string();
353 }
354 break;
355 default:
356 break;
357 }
358 }
359 }
360 }
361
362 return "<unknown>";
363 }
364
365 int CDSHeapVerifier::trace_to_root(outputStream* st, oop orig_obj, oop orig_field, HeapShared::CachedOopInfo* info) {
366 int level = 0;
367 if (info->orig_referrer() != nullptr) {
368 HeapShared::CachedOopInfo* ref = HeapShared::archived_object_cache()->get(info->orig_referrer());
369 assert(ref != nullptr, "sanity");
370 level = trace_to_root(st, info->orig_referrer(), orig_obj, ref) + 1;
371 } else if (java_lang_String::is_instance(orig_obj)) {
372 st->print_cr("[%2d] (shared string table)", level++);
373 }
374 Klass* k = orig_obj->klass();
375 ResourceMark rm;
376 st->print("[%2d] ", level);
377 orig_obj->print_address_on(st);
378 st->print(" %s", k->internal_name());
379 if (java_lang_Class::is_instance(orig_obj)) {
380 st->print(" (%s::%s)", java_lang_Class::as_Klass(orig_obj)->external_name(), static_field_name(orig_obj, orig_field));
381 }
382 if (orig_field != nullptr) {
383 if (k->is_instance_klass()) {
384 TraceFields clo(orig_obj, orig_field, st);
385 InstanceKlass::cast(k)->do_nonstatic_fields(&clo);
386 } else {
387 assert(orig_obj->is_objArray(), "must be");
388 objArrayOop array = (objArrayOop)orig_obj;
389 for (int i = 0; i < array->length(); i++) {
390 if (array->obj_at(i) == orig_field) {
391 st->print(" @[%d]", i);
392 break;
393 }
394 }
395 }
396 }
397 st->cr();
398
399 return level;
400 }
401
402 void CDSHeapVerifier::verify() {
403 CDSHeapVerifier verf;
404 HeapShared::archived_object_cache()->iterate(&verf);
405 }
406
407 #endif // INCLUDE_CDS_JAVA_HEAP