< prev index next >

src/hotspot/cpu/x86/continuationFreezeThaw_x86.inline.hpp

Print this page
@@ -1,7 +1,7 @@
  /*
-  * Copyright (c) 2019, 2023, Oracle and/or its affiliates. All rights reserved.
+  * Copyright (c) 2019, 2024, Oracle and/or its affiliates. All rights reserved.
   * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
   *
   * This code is free software; you can redistribute it and/or modify it
   * under the terms of the GNU General Public License version 2 only, as
   * published by the Free Software Foundation.

@@ -124,21 +124,29 @@
    if (real_unextended_sp != nullptr) {
      f.set_unextended_sp(real_unextended_sp); // can be null at a safepoint
    }
  }
  
+ inline void FreezeBase::prepare_freeze_interpreted_top_frame(frame& f) {
+   assert(f.interpreter_frame_last_sp() == nullptr, "should be null for top frame");
+   f.interpreter_frame_set_last_sp(f.unextended_sp());
+ }
+ 
  inline void FreezeBase::relativize_interpreted_frame_metadata(const frame& f, const frame& hf) {
    assert(hf.fp() == hf.unextended_sp() + (f.fp() - f.unextended_sp()), "");
    assert((f.at(frame::interpreter_frame_last_sp_offset) != 0)
      || (f.unextended_sp() == f.sp()), "");
    assert(f.fp() > (intptr_t*)f.at_relative(frame::interpreter_frame_initial_sp_offset), "");
  
    // Make sure that last_sp is already relativized.
    assert((intptr_t*)hf.at_relative(frame::interpreter_frame_last_sp_offset) == hf.unextended_sp(), "");
  
    // Make sure that locals is already relativized.
-   assert((*hf.addr_at(frame::interpreter_frame_locals_offset) == frame::sender_sp_offset + f.interpreter_frame_method()->max_locals() - 1), "");
+   DEBUG_ONLY(Method* m = f.interpreter_frame_method();)
+   // Frames for native methods have 2 extra words (temp oop/result handler) before fixed part of frame.
+   DEBUG_ONLY(int max_locals = !m->is_native() ? m->max_locals() : m->size_of_parameters() + 2;)
+   assert((*hf.addr_at(frame::interpreter_frame_locals_offset) == frame::sender_sp_offset + max_locals - 1), "");
  
    // Make sure that monitor_block_top is already relativized.
    assert(hf.at_absolute(frame::interpreter_frame_monitor_block_top_offset) <= frame::interpreter_frame_initial_sp_offset, "");
  
    assert((hf.fp() - hf.unextended_sp()) == (f.fp() - f.unextended_sp()), "");

@@ -205,29 +213,31 @@
    if (FKind::interpreted) {
      intptr_t* heap_sp = hf.unextended_sp();
      // If caller is interpreted it already made room for the callee arguments
      int overlap = caller.is_interpreted_frame() ? ContinuationHelper::InterpretedFrame::stack_argsize(hf) : 0;
      const int fsize = (int)(ContinuationHelper::InterpretedFrame::frame_bottom(hf) - hf.unextended_sp() - overlap);
-     const int locals = hf.interpreter_frame_method()->max_locals();
      intptr_t* frame_sp = caller.unextended_sp() - fsize;
      intptr_t* fp = frame_sp + (hf.fp() - heap_sp);
      DEBUG_ONLY(intptr_t* unextended_sp = fp + *hf.addr_at(frame::interpreter_frame_last_sp_offset);)
      assert(frame_sp == unextended_sp, "");
      caller.set_sp(fp + frame::sender_sp_offset);
      frame f(frame_sp, frame_sp, fp, hf.pc());
      // we need to set the locals so that the caller of new_stack_frame() can call
      // ContinuationHelper::InterpretedFrame::frame_bottom
      intptr_t locals_offset = *hf.addr_at(frame::interpreter_frame_locals_offset);
-     assert((int)locals_offset == frame::sender_sp_offset + locals - 1, "");
+     DEBUG_ONLY(Method* m = hf.interpreter_frame_method();)
+     // Frames for native methods have 2 extra words (temp oop/result handler) before fixed part of frame.
+     DEBUG_ONLY(const int max_locals = !m->is_native() ? m->max_locals() : m->size_of_parameters() + 2;)
+     assert((int)locals_offset == frame::sender_sp_offset + max_locals - 1, "");
      // copy relativized locals from the heap frame
      *f.addr_at(frame::interpreter_frame_locals_offset) = locals_offset;
      return f;
    } else {
      int fsize = FKind::size(hf);
      intptr_t* frame_sp = caller.unextended_sp() - fsize;
      if (bottom || caller.is_interpreted_frame()) {
-       int argsize = hf.compiled_frame_stack_argsize();
+       int argsize = FKind::stack_argsize(hf);
  
        fsize += argsize;
        frame_sp   -= argsize;
        caller.set_sp(caller.sp() - argsize);
        assert(caller.sp() == frame_sp + (fsize-argsize), "");

@@ -240,12 +250,13 @@
      intptr_t* fp;
      if (PreserveFramePointer) {
        // we need to recreate a "real" frame pointer, pointing into the stack
        fp = frame_sp + FKind::size(hf) - frame::sender_sp_offset;
      } else {
-        // we need to re-read fp because it may be an oop and we might have fixed the frame.
-       fp = *(intptr_t**)(hf.sp() - frame::sender_sp_offset);
+       fp = FKind::stub || FKind::native
+         ? frame_sp + fsize - frame::sender_sp_offset // fp always points to the address below the pushed return pc. We need correct address.
+         : *(intptr_t**)(hf.sp() - frame::sender_sp_offset); // we need to re-read fp because it may be an oop and we might have fixed the frame.
      }
      return frame(frame_sp, frame_sp, fp, hf.pc(), hf.cb(), hf.oop_map(), false); // TODO PERF : this computes deopt state; is it necessary?
    }
  }
  

@@ -264,10 +275,31 @@
  
  inline void ThawBase::patch_pd(frame& f, const frame& caller) {
    patch_callee_link(caller, caller.fp());
  }
  
+ inline void ThawBase::patch_pd(frame& f, intptr_t* caller_sp) {
+   intptr_t* fp = caller_sp - frame::sender_sp_offset;
+   patch_callee_link(f, fp);
+ }
+ 
+ inline intptr_t* ThawBase::possibly_adjust_frame(frame& top) {
+   // Nothing to do
+   return top.sp();
+ }
+ 
+ inline intptr_t* ThawBase::push_cleanup_continuation() {
+   frame enterSpecial = new_entry_frame();
+   intptr_t* sp = enterSpecial.sp();
+ 
+   sp[-1] = (intptr_t)ContinuationEntry::cleanup_pc();
+   sp[-2] = (intptr_t)enterSpecial.fp();
+ 
+   log_develop_trace(continuations, preempt)("push_cleanup_continuation initial sp: " INTPTR_FORMAT " final sp: " INTPTR_FORMAT, p2i(sp + 2 * frame::metadata_words), p2i(sp));
+   return sp;
+ }
+ 
  inline void ThawBase::derelativize_interpreted_frame_metadata(const frame& hf, const frame& f) {
    // Make sure that last_sp is kept relativized.
    assert((intptr_t*)f.at_relative(frame::interpreter_frame_last_sp_offset) == f.unextended_sp(), "");
  
    // Make sure that monitor_block_top is still relativized.
< prev index next >