< prev index next >

src/java.base/share/classes/jdk/internal/jrtfs/ExplodedImage.java

Print this page
@@ -22,25 +22,31 @@
   * or visit www.oracle.com if you need additional information or have any
   * questions.
   */
  package jdk.internal.jrtfs;
  
+ import jdk.internal.jimage.ImageReader.Node;
+ 
  import java.io.IOException;
  import java.io.UncheckedIOException;
  import java.nio.file.DirectoryStream;
  import java.nio.file.FileSystemException;
  import java.nio.file.Files;
  import java.nio.file.Path;
+ import java.nio.file.Paths;
  import java.nio.file.attribute.BasicFileAttributes;
  import java.util.ArrayList;
  import java.util.HashMap;
+ import java.util.HashSet;
  import java.util.List;
  import java.util.Map;
  import java.util.Objects;
+ import java.util.Set;
+ import java.util.regex.Pattern;
  import java.util.stream.Stream;
  
- import jdk.internal.jimage.ImageReader.Node;
+ import static java.util.stream.Collectors.toList;
  
  /**
   * A jrt file system built on $JAVA_HOME/modules directory ('exploded modules
   * build')
   *

@@ -52,56 +58,71 @@
   */
  class ExplodedImage extends SystemImage {
  
      private static final String MODULES = "/modules/";
      private static final String PACKAGES = "/packages/";
+     private static final Path META_INF_DIR = Paths.get("META-INF");
+     private static final Path PREVIEW_DIR = META_INF_DIR.resolve("preview");
  
      private final Path modulesDir;
+     private final boolean isPreviewMode;
      private final String separator;
      private final Map<String, PathNode> nodes = new HashMap<>();
      private final BasicFileAttributes modulesDirAttrs;
  
-     ExplodedImage(Path modulesDir) throws IOException {
+     ExplodedImage(Path modulesDir, boolean isPreviewMode) throws IOException {
          this.modulesDir = modulesDir;
+         this.isPreviewMode = isPreviewMode;
          String str = modulesDir.getFileSystem().getSeparator();
          separator = str.equals("/") ? null : str;
          modulesDirAttrs = Files.readAttributes(modulesDir, BasicFileAttributes.class);
          initNodes();
      }
  
      // A Node that is backed by actual default file system Path
      private final class PathNode extends Node {
- 
-         // Path in underlying default file system
-         private Path path;
+         // Path in underlying default file system relative to modulesDir.
+         // In preview mode this need not correspond to the node's name.
+         private Path relPath;
          private PathNode link;
-         private List<Node> children;
+         private List<String> childNames;
  
+         /**
+          * Creates a file based node with the given file attributes.
+          *
+          * <p>If the underlying path is a directory, then it is created in an
+          * "incomplete" state, and its child names will be determined lazily.
+          */
          private PathNode(String name, Path path, BasicFileAttributes attrs) {  // path
              super(name, attrs);
-             this.path = path;
+             this.relPath = modulesDir.relativize(path);
+             if (relPath.isAbsolute() || relPath.getNameCount() == 0) {
+                 throw new IllegalArgumentException("Invalid node path (must be relative): " + path);
+             }
          }
  
+         /** Creates a symbolic link node to the specified target. */
          private PathNode(String name, Node link) {              // link
              super(name, link.getFileAttributes());
              this.link = (PathNode)link;
          }
  
-         private PathNode(String name, List<Node> children) {    // dir
+         /** Creates a completed directory node based a list of child nodes. */
+         private PathNode(String name, List<PathNode> children) {    // dir
              super(name, modulesDirAttrs);
-             this.children = children;
+             this.childNames = children.stream().map(Node::getName).collect(toList());
          }
  
          @Override
          public boolean isResource() {
              return link == null && !getFileAttributes().isDirectory();
          }
  
          @Override
          public boolean isDirectory() {
-             return children != null ||
-                    (link == null && getFileAttributes().isDirectory());
+             return childNames != null ||
+                     (link == null && getFileAttributes().isDirectory());
          }
  
          @Override
          public boolean isLink() {
              return link != null;

@@ -115,40 +136,61 @@
          }
  
          private byte[] getContent() throws IOException {
              if (!getFileAttributes().isRegularFile())
                  throw new FileSystemException(getName() + " is not file");
-             return Files.readAllBytes(path);
+             return Files.readAllBytes(modulesDir.resolve(relPath));
          }
  
          @Override
          public Stream<String> getChildNames() {
              if (!isDirectory())
-                 throw new IllegalArgumentException("not a directory: " + getName());
-             if (children == null) {
-                 List<Node> list = new ArrayList<>();
-                 try (DirectoryStream<Path> stream = Files.newDirectoryStream(path)) {
-                     for (Path p : stream) {
-                         p = modulesDir.relativize(p);
-                         String pName = MODULES + nativeSlashToFrontSlash(p.toString());
-                         Node node = findNode(pName);
-                         if (node != null) {  // findNode may choose to hide certain files!
-                             list.add(node);
-                         }
+                 throw new IllegalStateException("not a directory: " + getName());
+             List<String> names = childNames;
+             if (names == null) {
+                 names = completeDirectory();
+             }
+             return names.stream();
+         }
+ 
+         private synchronized List<String> completeDirectory() {
+             if (childNames != null) {
+                 return childNames;
+             }
+             // Process preview nodes first, so if nodes are created they take
+             // precedence in the cache.
+             Set<String> childNameSet = new HashSet<>();
+             if (isPreviewMode && relPath.getNameCount() > 1 && !relPath.getName(1).equals(META_INF_DIR)) {
+                 Path absPreviewDir = modulesDir
+                         .resolve(relPath.getName(0))
+                         .resolve(PREVIEW_DIR)
+                         .resolve(relPath.subpath(1, relPath.getNameCount()));
+                 if (Files.exists(absPreviewDir)) {
+                     collectChildNodeNames(absPreviewDir, childNameSet);
+                 }
+             }
+             collectChildNodeNames(modulesDir.resolve(relPath), childNameSet);
+             return childNames = childNameSet.stream().sorted().collect(toList());
+         }
+ 
+         private void collectChildNodeNames(Path absPath, Set<String> childNameSet) {
+             try (DirectoryStream<Path> stream = Files.newDirectoryStream(absPath)) {
+                 for (Path p : stream) {
+                     PathNode node = (PathNode) findNode(getName() + "/" + p.getFileName().toString());
+                     if (node != null) {  // findNode may choose to hide certain files!
+                         childNameSet.add(node.getName());
                      }
-                 } catch (IOException x) {
-                     return null;
                  }
-                 children = list;
+             } catch (IOException ex) {
+                 throw new UncheckedIOException(ex);
              }
-             return children.stream().map(Node::getName);
          }
  
          @Override
          public long size() {
              try {
-                 return isDirectory() ? 0 : Files.size(path);
+                 return isDirectory() ? 0 : Files.size(modulesDir.resolve(relPath));
              } catch (IOException ex) {
                  throw new UncheckedIOException(ex);
              }
          }
      }

@@ -178,22 +220,58 @@
          }
          // This can still return null for hidden files.
          return createModulesNode(name, path);
      }
  
+     /**
+      * Returns the expected file path for name in the "/modules/..." namespace,
+      * or {@code null} if the name is not in the "/modules/..." namespace or the
+      * path does not reference a file.
+      */
+     private Path underlyingModulesPath(String name) {
+         if (!isNonEmptyModulesName(name)) {
+             return null;
+         }
+         String relName = name.substring(MODULES.length());
+         Path relPath = Paths.get(frontSlashToNativeSlash(relName));
+         // The first path segment must exist due to check above.
+         Path modDir = relPath.getName(0);
+         Path previewDir = modDir.resolve(PREVIEW_DIR);
+         if (relPath.startsWith(previewDir)) {
+             return null;
+         }
+         Path path = modulesDir.resolve(relPath);
+         // Non-preview directories take precedence.
+         if (Files.isDirectory(path)) {
+             return path;
+         }
+         // Otherwise prefer preview resources over non-preview ones.
+         if (isPreviewMode
+                 && relPath.getNameCount() > 1
+                 && !modDir.equals(META_INF_DIR)) {
+             Path previewPath = modulesDir
+                     .resolve(previewDir)
+                     .resolve(relPath.subpath(1, relPath.getNameCount()));
+             if (Files.exists(previewPath)) {
+                 return previewPath;
+             }
+         }
+         return Files.exists(path) ? path : null;
+     }
+ 
      /**
       * Lazily creates and caches a {@code Node} for the given "/modules/..." name
       * and corresponding path to a file or directory.
       *
       * @param name a resource or directory node name, of the form "/modules/...".
       * @param path the path of a file for a resource or directory.
       * @return the newly created and cached node, or {@code null} if the given
       *     path references a file which must be hidden in the node hierarchy.
       */
-     private Node createModulesNode(String name, Path path) {
+     private PathNode createModulesNode(String name, Path path) {
          assert !nodes.containsKey(name) : "Node must not already exist: " + name;
-         assert isNonEmptyModulesPath(name) : "Invalid modules name: " + name;
+         assert isNonEmptyModulesName(name) : "Invalid modules name: " + name;
  
          try {
              // We only know if we're creating a resource of directory when we
              // look up file attributes, and we only do that once. Thus, we can
              // only reject "marker files" here, rather than by inspecting the

@@ -209,44 +287,33 @@
              }
              PathNode node = new PathNode(name, path, attrs);
              nodes.put(name, node);
              return node;
          } catch (IOException x) {
-             // Since the path reference a file, any errors should not be ignored.
+             // Since the path references a file errors should not be ignored.
              throw new UncheckedIOException(x);
          }
      }
  
-     /**
-      * Returns the expected file path for name in the "/modules/..." namespace,
-      * or {@code null} if the name is not in the "/modules/..." namespace or the
-      * path does not reference a file.
-      */
-     private Path underlyingModulesPath(String name) {
-         if (isNonEmptyModulesPath(name)) {
-             Path path = modulesDir.resolve(frontSlashToNativeSlash(name.substring(MODULES.length())));
-             return Files.exists(path) ? path : null;
-         }
-         return null;
-     }
+     private static final Pattern NON_EMPTY_MODULES_NAME =
+             Pattern.compile("/modules(/[^/]+)+");
  
-     private static boolean isNonEmptyModulesPath(String name) {
+     private static boolean isNonEmptyModulesName(String name) {
          // Don't just check the prefix, there must be something after it too
          // (otherwise you end up with an empty string after trimming).
-         return name.startsWith(MODULES) && name.length() > MODULES.length();
+         // Also make sure we can't be tricked by "/modules//absolute/path" or
+         // "/modules/../../escaped/path"
+         return NON_EMPTY_MODULES_NAME.matcher(name).matches()
+                 && !name.contains("/../")
+                 && !name.contains("/./");
      }
  
      // convert "/" to platform path separator
      private String frontSlashToNativeSlash(String str) {
          return separator == null ? str : str.replace("/", separator);
      }
  
-     // convert platform path separator to "/"
-     private String nativeSlashToFrontSlash(String str) {
-         return separator == null ? str : str.replace(separator, "/");
-     }
- 
      // convert "/"s to "."s
      private String slashesToDots(String str) {
          return str.replace(separator != null ? separator : "/", ".");
      }
  

@@ -254,41 +321,27 @@
      private void initNodes() throws IOException {
          // same package prefix may exist in multiple modules. This Map
          // is filled by walking "jdk modules" directory recursively!
          Map<String, List<String>> packageToModules = new HashMap<>();
          try (DirectoryStream<Path> stream = Files.newDirectoryStream(modulesDir)) {
-             for (Path module : stream) {
-                 if (Files.isDirectory(module)) {
-                     String moduleName = module.getFileName().toString();
-                     // make sure "/modules/<moduleName>" is created
-                     Objects.requireNonNull(createModulesNode(MODULES + moduleName, module));
-                     try (Stream<Path> contentsStream = Files.walk(module)) {
-                         contentsStream.filter(Files::isDirectory).forEach((p) -> {
-                             p = module.relativize(p);
-                             String pkgName = slashesToDots(p.toString());
-                             // skip META-INF and empty strings
-                             if (!pkgName.isEmpty() && !pkgName.startsWith("META-INF")) {
-                                 packageToModules
-                                         .computeIfAbsent(pkgName, k -> new ArrayList<>())
-                                         .add(moduleName);
-                             }
-                         });
-                     }
+             for (Path moduleDir : stream) {
+                 if (Files.isDirectory(moduleDir)) {
+                     processModuleDirectory(moduleDir, packageToModules);
                  }
              }
          }
          // create "/modules" directory
          // "nodes" map contains only /modules/<foo> nodes only so far and so add all as children of /modules
          PathNode modulesRootNode = new PathNode("/modules", new ArrayList<>(nodes.values()));
          nodes.put(modulesRootNode.getName(), modulesRootNode);
  
          // create children under "/packages"
-         List<Node> packagesChildren = new ArrayList<>(packageToModules.size());
+         List<PathNode> packagesChildren = new ArrayList<>(packageToModules.size());
          for (Map.Entry<String, List<String>> entry : packageToModules.entrySet()) {
              String pkgName = entry.getKey();
              List<String> moduleNameList = entry.getValue();
-             List<Node> moduleLinkNodes = new ArrayList<>(moduleNameList.size());
+             List<PathNode> moduleLinkNodes = new ArrayList<>(moduleNameList.size());
              for (String moduleName : moduleNameList) {
                  Node moduleNode = Objects.requireNonNull(nodes.get(MODULES + moduleName));
                  PathNode linkNode = new PathNode(PACKAGES + pkgName + "/" + moduleName, moduleNode);
                  nodes.put(linkNode.getName(), linkNode);
                  moduleLinkNodes.add(linkNode);

@@ -300,12 +353,42 @@
          // "/packages" dir
          PathNode packagesRootNode = new PathNode("/packages", packagesChildren);
          nodes.put(packagesRootNode.getName(), packagesRootNode);
  
          // finally "/" dir!
-         List<Node> rootChildren = new ArrayList<>();
+         List<PathNode> rootChildren = new ArrayList<>();
          rootChildren.add(packagesRootNode);
          rootChildren.add(modulesRootNode);
          PathNode root = new PathNode("/", rootChildren);
          nodes.put(root.getName(), root);
      }
+ 
+     private void processModuleDirectory(Path moduleDir, Map<String, List<String>> packageToModules)
+             throws IOException {
+         String moduleName = moduleDir.getFileName().toString();
+         // Make sure "/modules/<moduleName>" is created
+         Objects.requireNonNull(createModulesNode(MODULES + moduleName, moduleDir));
+         // Skip the first path (it's always the given root directory).
+         try (Stream<Path> contentsStream = Files.walk(moduleDir).skip(1)) {
+             contentsStream
+                     // Non-empty relative directory paths inside each module.
+                     .filter(Files::isDirectory)
+                     .map(moduleDir::relativize)
+                     // Map paths inside preview directory to non-preview versions.
+                     .filter(p -> isPreviewMode || !p.startsWith(PREVIEW_DIR))
+                     .map(p -> isPreviewSubpath(p) ? PREVIEW_DIR.relativize(p) : p)
+                     // Ignore special META-INF directory (including preview directory itself).
+                     .filter(p -> !p.startsWith(META_INF_DIR))
+                     // Extract unique package names.
+                     .map(p -> slashesToDots(p.toString()))
+                     .distinct()
+                     .forEach(pkgName ->
+                             packageToModules
+                                     .computeIfAbsent(pkgName, k -> new ArrayList<>())
+                                     .add(moduleName));
+         }
+     }
+ 
+     private static boolean isPreviewSubpath(Path p) {
+         return p.startsWith(PREVIEW_DIR) && p.getNameCount() > PREVIEW_DIR.getNameCount();
+     }
  }
< prev index next >