Code Review for project openjdk/jdk-sandbox/shen-late-barriers against openjdk/jdk-sandbox/master

Prepared by: Buildbot on Tue May 05 05:10:00 CEST 2026
Compare against version: 3c69c969
Summary of changes: 10171 lines changed; 5575 ins; 3698 del; 898 mod; 58274 unchg
Patch of changes: master.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw .gitignore

3 lines changed; 3 ins; 0 del; 0 mod; 32 unchg

------ ------ ------ ------ --- New Patch Raw run-dacapo.sh

89 lines changed; 89 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw run-helloworld.sh

71 lines changed; 71 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw run-renaissance.sh

90 lines changed; 90 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/aarch64/aarch64.ad

6 lines changed; 0 ins; 6 del; 0 mod; 16547 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.cpp

431 lines changed; 431 ins; 0 del; 0 mod; 833 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.hpp

27 lines changed; 20 ins; 7 del; 0 mod; 73 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/aarch64/gc/shenandoah/shenandoah_aarch64.ad

470 lines changed; 334 ins; 6 del; 130 mod; 117 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/ppc/gc/shenandoah/shenandoahBarrierSetAssembler_ppc.cpp

299 lines changed; 299 ins; 0 del; 0 mod; 1093 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/ppc/gc/shenandoah/shenandoahBarrierSetAssembler_ppc.hpp

24 lines changed; 24 ins; 0 del; 0 mod; 130 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/ppc/gc/shenandoah/shenandoah_ppc.ad

362 lines changed; 249 ins; 11 del; 102 mod; 93 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/riscv/gc/shenandoah/shenandoahBarrierSetAssembler_riscv.cpp

387 lines changed; 387 ins; 0 del; 0 mod; 770 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/riscv/gc/shenandoah/shenandoahBarrierSetAssembler_riscv.hpp

31 lines changed; 24 ins; 7 del; 0 mod; 78 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/riscv/gc/shenandoah/shenandoah_riscv.ad

352 lines changed; 171 ins; 33 del; 148 mod; 71 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/riscv/riscv.ad

6 lines changed; 0 ins; 6 del; 0 mod; 11542 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.cpp

417 lines changed; 417 ins; 0 del; 0 mod; 903 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.hpp

27 lines changed; 21 ins; 6 del; 0 mod; 70 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/gc/shenandoah/shenandoah_x86_64.ad

201 lines changed; 140 ins; 15 del; 46 mod; 35 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/adlc/formssel.cpp

7 lines changed; 0 ins; 7 del; 0 mod; 4484 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/c2/g1BarrierSetC2.cpp

1 lines changed; 0 ins; 0 del; 1 mod; 592 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/c2/g1BarrierSetC2.hpp

1 lines changed; 0 ins; 0 del; 1 mod; 113 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/c2/barrierSetC2.cpp

8 lines changed; 6 ins; 0 del; 2 mod; 1231 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/c2/barrierSetC2.hpp

3 lines changed; 2 ins; 0 del; 1 mod; 394 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.cpp

1416 lines changed; 304 ins; 697 del; 415 mod; -459 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.hpp

206 lines changed; 116 ins; 62 del; 28 mod; 12 unchg

------ ------ ------ ------ Old --- Patch Raw src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp

2533 lines changed; 0 ins; 2533 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch Raw src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.hpp

251 lines changed; 0 ins; 251 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp

14 lines changed; 0 ins; 14 del; 0 mod; 226 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahAsserts.cpp

11 lines changed; 11 ins; 0 del; 0 mod; 582 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahAsserts.hpp

13 lines changed; 13 ins; 0 del; 0 mod; 257 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.cpp

7 lines changed; 0 ins; 7 del; 0 mod; 192 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.hpp

3 lines changed; 0 ins; 2 del; 1 mod; 206 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.inline.hpp

69 lines changed; 63 ins; 0 del; 6 mod; 517 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahConcurrentGC.cpp

9 lines changed; 9 ins; 0 del; 0 mod; 1394 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp

16 lines changed; 15 ins; 1 del; 0 mod; 2970 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahRuntime.cpp

29 lines changed; 16 ins; 2 del; 11 mod; 64 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahRuntime.hpp

7 lines changed; 5 ins; 0 del; 2 mod; 51 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahThreadLocalData.hpp

51 lines changed; 50 ins; 0 del; 1 mod; 198 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoah_globals.hpp

16 lines changed; 16 ins; 0 del; 0 mod; 588 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/c2/zBarrierSetC2.cpp

1 lines changed; 0 ins; 0 del; 1 mod; 588 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/c2/zBarrierSetC2.hpp

1 lines changed; 0 ins; 0 del; 1 mod; 141 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/classes.hpp

12 lines changed; 0 ins; 12 del; 0 mod; 528 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/loopTransform.cpp

7 lines changed; 0 ins; 6 del; 1 mod; 4206 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/type.cpp

7 lines changed; 0 ins; 7 del; 0 mod; 6607 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/ProblemList.txt

3 lines changed; 3 ins; 0 del; 0 mod; 205 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/gc/shenandoah/compiler/TestShenandoahLoadRefBarrier.java

62 lines changed; 62 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/arraycopy/RefArray.java

70 lines changed; 70 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/cas/KnownExpectNull.java

55 lines changed; 55 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/cas/KnownUpdateNull.java

55 lines changed; 55 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/cas/RefFailure.java

57 lines changed; 57 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/cas/RefSuccess.java

57 lines changed; 57 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/clone/IntArray.java

55 lines changed; 55 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/clone/Plain.java

124 lines changed; 124 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/clone/RefArray.java

66 lines changed; 66 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/combining/ReadRead.java

59 lines changed; 59 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/reads/List.java

71 lines changed; 71 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/reads/MultipleObjects.java

63 lines changed; 63 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/reads/MultiplePrimFields.java

66 lines changed; 66 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/reads/MultipleRefFields.java

73 lines changed; 73 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/reads/NewObject.java

65 lines changed; 65 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/reads/NullChecks.java

62 lines changed; 62 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/reads/PrimArray.java

58 lines changed; 58 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/reads/RefArray.java

61 lines changed; 61 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/reads/SameObjectLoaded.java

161 lines changed; 161 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/reads/Single.java

63 lines changed; 63 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/reads/SingleVolatile.java

63 lines changed; 63 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/reads/Tree.java

83 lines changed; 83 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/reads/WeakRef.java

56 lines changed; 56 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/writes/MultipleKnownNulls.java

62 lines changed; 62 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/writes/MultiplePrimFields.java

72 lines changed; 72 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/writes/MultipleRefFields.java

75 lines changed; 75 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/writes/MultipleZeroes.java

63 lines changed; 63 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/writes/NewObject.java

63 lines changed; 63 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/writes/NullChecks.java

62 lines changed; 62 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/writes/Single.java

59 lines changed; 59 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/writes/SingleKnownNull.java

57 lines changed; 57 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/writes/SingleVolatile.java

58 lines changed; 58 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using webrev version 8aab2a590929de7d98c8bd1e8c6cf12e40cb6433