Code Review for project openjdk/jdk-sandbox/shen-late-barriers against openjdk/jdk-sandbox/master

Prepared by: Buildbot on Sat Feb 07 05:00:55 CET 2026
Compare against version: 60366a97
Summary of changes: 8251 lines changed; 3866 ins; 3918 del; 467 mod; 79759 unchg
Patch of changes: master.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw .gitignore

4 lines changed; 4 ins; 0 del; 0 mod; 33 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/aarch64/aarch64.ad

6 lines changed; 0 ins; 6 del; 0 mod; 16511 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.cpp

311 lines changed; 311 ins; 0 del; 0 mod; 803 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.hpp

10 lines changed; 10 ins; 0 del; 0 mod; 86 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/aarch64/gc/shenandoah/shenandoah_aarch64.ad

995 lines changed; 867 ins; 15 del; 113 mod; 116 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/cpu/aarch64/gc/shenandoah/shenandoah_aarch64.m4

370 lines changed; 370 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/gc/shared/barrierSetAssembler_x86.hpp

1 lines changed; 1 ins; 0 del; 0 mod; 163 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.cpp

469 lines changed; 468 ins; 0 del; 1 mod; 992 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.hpp

14 lines changed; 14 ins; 0 del; 0 mod; 82 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/gc/shenandoah/shenandoah_x86_64.ad

260 lines changed; 219 ins; 0 del; 41 mod; 70 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/adlc/formssel.cpp

7 lines changed; 0 ins; 7 del; 0 mod; 4480 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/c2/barrierSetC2.hpp

27 lines changed; 3 ins; 24 del; 0 mod; 341 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/satbMarkQueue.hpp

2 lines changed; 0 ins; 0 del; 2 mod; 299 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.cpp

1279 lines changed; 245 ins; 784 del; 250 mod; -496 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.hpp

196 lines changed; 116 ins; 57 del; 23 mod; 18 unchg

------ ------ ------ ------ Old --- Patch Raw src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp

2513 lines changed; 0 ins; 2513 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch Raw src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.hpp

251 lines changed; 0 ins; 251 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp

14 lines changed; 0 ins; 14 del; 0 mod; 214 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahAsserts.cpp

11 lines changed; 11 ins; 0 del; 0 mod; 584 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahAsserts.hpp

13 lines changed; 13 ins; 0 del; 0 mod; 257 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.cpp

7 lines changed; 0 ins; 7 del; 0 mod; 197 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.hpp

2 lines changed; 0 ins; 2 del; 0 mod; 208 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.inline.hpp

68 lines changed; 64 ins; 0 del; 4 mod; 490 unchg

------ ------ ------ ------ Old --- Patch Raw src/hotspot/share/gc/shenandoah/shenandoahBarrierSetClone.inline.hpp

105 lines changed; 0 ins; 105 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahMarkBitMap.hpp

1 lines changed; 0 ins; 1 del; 0 mod; 194 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahRuntime.cpp

13 lines changed; 7 ins; 3 del; 3 mod; 70 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahRuntime.hpp

3 lines changed; 2 ins; 0 del; 1 mod; 52 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoah_globals.hpp

3 lines changed; 3 ins; 0 del; 0 mod; 550 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/arraycopynode.cpp

3 lines changed; 0 ins; 2 del; 1 mod; 788 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/callnode.cpp

12 lines changed; 0 ins; 6 del; 6 mod; 2417 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/classes.hpp

12 lines changed; 0 ins; 12 del; 0 mod; 522 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/compile.cpp

18 lines changed; 8 ins; 8 del; 2 mod; 5541 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/escape.cpp

19 lines changed; 0 ins; 15 del; 4 mod; 5215 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/graphKit.cpp

3 lines changed; 0 ins; 3 del; 0 mod; 4282 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/loopTransform.cpp

7 lines changed; 0 ins; 6 del; 1 mod; 4099 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/loopnode.cpp

11 lines changed; 0 ins; 7 del; 4 mod; 7297 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/macro.cpp

9 lines changed; 0 ins; 6 del; 3 mod; 2754 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/matcher.cpp

7 lines changed; 0 ins; 5 del; 2 mod; 2952 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/memnode.cpp

21 lines changed; 6 ins; 12 del; 3 mod; 6007 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/memnode.hpp

7 lines changed; 7 ins; 0 del; 0 mod; 1718 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/node.cpp

7 lines changed; 0 ins; 7 del; 0 mod; 3172 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/phaseX.cpp

38 lines changed; 0 ins; 36 del; 2 mod; 3498 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/phaseX.hpp

1 lines changed; 0 ins; 1 del; 0 mod; 738 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/subnode.cpp

3 lines changed; 0 ins; 3 del; 0 mod; 2058 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/shenandoah/compiler/TestClone.java

149 lines changed; 148 ins; 0 del; 1 mod; 387 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/gc/shenandoah/compiler/TestShenandoahLoadRefBarrier.java

62 lines changed; 62 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/arraycopy/RefArray.java

46 lines changed; 46 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/cas/KnownExpectNull.java

34 lines changed; 34 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/cas/KnownUpdateNull.java

34 lines changed; 34 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/cas/RefFailure.java

33 lines changed; 33 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/cas/RefSuccess.java

33 lines changed; 33 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/clone/IntArray.java

31 lines changed; 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/clone/Plain.java

100 lines changed; 100 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/clone/RefArray.java

42 lines changed; 42 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/reads/IntArray.java

34 lines changed; 34 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/reads/IntenseLoadRefs.java

64 lines changed; 64 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/reads/MultipleIntFields.java

43 lines changed; 43 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/reads/MultipleObjects.java

39 lines changed; 39 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/reads/MultipleRefFields.java

50 lines changed; 50 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/reads/RefArray.java

37 lines changed; 37 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/reads/Single.java

39 lines changed; 39 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/reads/SingleVolatile.java

39 lines changed; 39 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/reads/WeakRef.java

32 lines changed; 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/writes/MultipleKnownNulls.java

38 lines changed; 38 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/writes/MultipleZeroes.java

39 lines changed; 39 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/writes/Single.java

34 lines changed; 34 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/writes/SingleKnownNull.java

33 lines changed; 33 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/writes/SingleVolatile.java

33 lines changed; 33 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using webrev version 8aab2a590929de7d98c8bd1e8c6cf12e40cb6433