Code Review for project openjdk/jdk-sandbox/shen-late-barriers against openjdk/jdk-sandbox/master

Prepared by: Buildbot on Fri Apr 03 05:00:59 CEST 2026
Compare against version: 9bf67a64
Summary of changes: 10660 lines changed; 5912 ins; 4086 del; 662 mod; 109246 unchg
Patch of changes: master.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw .gitignore

3 lines changed; 3 ins; 0 del; 0 mod; 34 unchg

------ ------ ------ ------ --- New Patch Raw run-dacapo.sh

89 lines changed; 89 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw run-helloworld.sh

67 lines changed; 67 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw run-renaissance.sh

90 lines changed; 90 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/aarch64/aarch64.ad

6 lines changed; 0 ins; 6 del; 0 mod; 16546 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.cpp

559 lines changed; 559 ins; 0 del; 0 mod; 828 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.hpp

87 lines changed; 78 ins; 7 del; 2 mod; 74 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/aarch64/gc/shenandoah/shenandoah_aarch64.ad

289 lines changed; 134 ins; 20 del; 135 mod; 84 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp

1 lines changed; 0 ins; 0 del; 1 mod; 7235 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/aarch64/nativeInst_aarch64.cpp

1 lines changed; 1 ins; 0 del; 0 mod; 429 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/aarch64/register_aarch64.hpp

5 lines changed; 5 ins; 0 del; 0 mod; 546 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp

124 lines changed; 124 ins; 0 del; 0 mod; 2907 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/ppc/gc/shenandoah/shenandoahBarrierSetAssembler_ppc.cpp

24 lines changed; 24 ins; 0 del; 0 mod; 1091 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/ppc/gc/shenandoah/shenandoahBarrierSetAssembler_ppc.hpp

25 lines changed; 25 ins; 0 del; 0 mod; 129 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/ppc/gc/shenandoah/shenandoah_ppc.ad

187 lines changed; 0 ins; 187 del; 0 mod; -157 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/ppc/sharedRuntime_ppc.cpp

10 lines changed; 10 ins; 0 del; 0 mod; 3837 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/riscv/gc/shenandoah/shenandoahBarrierSetAssembler_riscv.cpp

457 lines changed; 457 ins; 0 del; 0 mod; 779 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/riscv/gc/shenandoah/shenandoahBarrierSetAssembler_riscv.hpp

31 lines changed; 23 ins; 6 del; 2 mod; 81 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/riscv/gc/shenandoah/shenandoah_riscv.ad

210 lines changed; 72 ins; 23 del; 115 mod; 124 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/riscv/register_riscv.hpp

5 lines changed; 5 ins; 0 del; 0 mod; 415 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/riscv/riscv.ad

6 lines changed; 0 ins; 6 del; 0 mod; 11542 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/riscv/sharedRuntime_riscv.cpp

114 lines changed; 114 ins; 0 del; 0 mod; 2784 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.cpp

486 lines changed; 486 ins; 0 del; 0 mod; 1015 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.hpp

31 lines changed; 24 ins; 6 del; 1 mod; 73 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/gc/shenandoah/shenandoah_x86_64.ad

201 lines changed; 141 ins; 15 del; 45 mod; 36 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/sharedRuntime_x86_64.cpp

160 lines changed; 145 ins; 8 del; 7 mod; 3580 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/stubGenerator_x86_64.cpp

1 lines changed; 1 ins; 0 del; 0 mod; 4355 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/adlc/formssel.cpp

7 lines changed; 0 ins; 7 del; 0 mod; 4482 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/asm/assembler.hpp

2 lines changed; 2 ins; 0 del; 0 mod; 514 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/asm/codeBuffer.hpp

8 lines changed; 8 ins; 0 del; 0 mod; 908 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/c2/barrierSetC2.hpp

1 lines changed; 1 ins; 0 del; 0 mod; 395 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.cpp

1492 lines changed; 363 ins; 814 del; 315 mod; -593 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.hpp

237 lines changed; 155 ins; 60 del; 22 mod; 22 unchg

------ ------ ------ ------ Old --- Patch Raw src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp

2513 lines changed; 0 ins; 2513 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch Raw src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.hpp

251 lines changed; 0 ins; 251 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp

14 lines changed; 0 ins; 14 del; 0 mod; 214 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahAsserts.cpp

11 lines changed; 11 ins; 0 del; 0 mod; 582 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahAsserts.hpp

13 lines changed; 13 ins; 0 del; 0 mod; 257 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.cpp

7 lines changed; 0 ins; 7 del; 0 mod; 196 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.hpp

2 lines changed; 0 ins; 2 del; 0 mod; 208 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.inline.hpp

68 lines changed; 64 ins; 0 del; 4 mod; 490 unchg

------ ------ ------ ------ Old --- Patch Raw src/hotspot/share/gc/shenandoah/shenandoahBarrierSetClone.inline.hpp

105 lines changed; 0 ins; 105 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp

19 lines changed; 16 ins; 1 del; 2 mod; 2859 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahRuntime.cpp

5 lines changed; 0 ins; 3 del; 2 mod; 71 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahRuntime.hpp

2 lines changed; 1 ins; 0 del; 1 mod; 52 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahThreadLocalData.hpp

63 lines changed; 62 ins; 0 del; 1 mod; 212 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoah_globals.hpp

12 lines changed; 12 ins; 0 del; 0 mod; 599 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/classes.hpp

12 lines changed; 0 ins; 12 del; 0 mod; 525 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/compile.cpp

5 lines changed; 2 ins; 0 del; 3 mod; 5525 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/loopTransform.cpp

7 lines changed; 0 ins; 6 del; 1 mod; 4121 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/machnode.cpp

37 lines changed; 37 ins; 0 del; 0 mod; 896 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/machnode.hpp

22 lines changed; 22 ins; 0 del; 0 mod; 1163 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/matcher.cpp

2 lines changed; 2 ins; 0 del; 0 mod; 2964 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/memnode.cpp

9 lines changed; 9 ins; 0 del; 0 mod; 6149 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/memnode.hpp

8 lines changed; 7 ins; 0 del; 1 mod; 1800 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/output.cpp

6 lines changed; 5 ins; 0 del; 1 mod; 3404 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/output.hpp

6 lines changed; 6 ins; 0 del; 0 mod; 226 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/type.cpp

7 lines changed; 0 ins; 7 del; 0 mod; 6607 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/sharedRuntime.cpp

25 lines changed; 25 ins; 0 del; 0 mod; 3510 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/sharedRuntime.hpp

73 lines changed; 73 ins; 0 del; 0 mod; 874 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/stubDeclarations.hpp

15 lines changed; 15 ins; 0 del; 0 mod; 1260 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/shenandoah/compiler/TestClone.java

149 lines changed; 148 ins; 0 del; 1 mod; 387 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/gc/shenandoah/compiler/TestShenandoahLoadRefBarrier.java

62 lines changed; 62 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/arraycopy/RefArray.java

70 lines changed; 70 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/cas/KnownExpectNull.java

55 lines changed; 55 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/cas/KnownUpdateNull.java

55 lines changed; 55 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/cas/RefFailure.java

57 lines changed; 57 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/cas/RefSuccess.java

57 lines changed; 57 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/clone/IntArray.java

55 lines changed; 55 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/clone/Plain.java

124 lines changed; 124 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/clone/RefArray.java

66 lines changed; 66 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/combining/ReadRead.java

59 lines changed; 59 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/reads/List.java

71 lines changed; 71 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/reads/MultipleObjects.java

63 lines changed; 63 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/reads/MultiplePrimFields.java

66 lines changed; 66 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/reads/MultipleRefFields.java

73 lines changed; 73 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/reads/NewObject.java

65 lines changed; 65 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/reads/NullChecks.java

62 lines changed; 62 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/reads/PrimArray.java

58 lines changed; 58 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/reads/RefArray.java

61 lines changed; 61 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/reads/SameObjectLoaded.java

161 lines changed; 161 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/reads/Single.java

63 lines changed; 63 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/reads/SingleVolatile.java

63 lines changed; 63 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/reads/Tree.java

83 lines changed; 83 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/reads/WeakRef.java

56 lines changed; 56 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/writes/MultipleKnownNulls.java

62 lines changed; 62 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/writes/MultiplePrimFields.java

72 lines changed; 72 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/writes/MultipleRefFields.java

75 lines changed; 75 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/writes/MultipleZeroes.java

63 lines changed; 63 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/writes/NewObject.java

63 lines changed; 63 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/writes/NullChecks.java

62 lines changed; 62 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/writes/Single.java

59 lines changed; 59 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/writes/SingleKnownNull.java

57 lines changed; 57 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/vm/gc/barriers/writes/SingleVolatile.java

58 lines changed; 58 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using webrev version 8aab2a590929de7d98c8bd1e8c6cf12e40cb6433