Code Review for project openjdk/lilliput-jdk21u/lilliput against openjdk/jdk21u/master

Prepared by: Buildbot on Thu Oct 03 05:01:48 CEST 2024
Compare against version: 07fc6246
Summary of changes: 8210 lines changed; 6027 ins; 1388 del; 795 mod; 300865 unchg
Patch of changes: master.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw .jcheck/conf

2 lines changed; 0 ins; 0 del; 2 mod; 33 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/Images.gmk

17 lines changed; 14 ins; 0 del; 3 mod; 309 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/RunTests.gmk

5 lines changed; 5 ins; 0 del; 0 mod; 1248 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/autoconf/configure.ac

1 lines changed; 1 ins; 0 del; 0 mod; 321 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/autoconf/jdk-options.m4

27 lines changed; 27 ins; 0 del; 0 mod; 927 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/autoconf/spec.gmk.in

1 lines changed; 1 ins; 0 del; 0 mod; 1004 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/aarch64/aarch64.ad

51 lines changed; 47 ins; 2 del; 2 mod; 17546 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/aarch64/c1_CodeStubs_aarch64.cpp

8 lines changed; 8 ins; 0 del; 0 mod; 353 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/aarch64/c1_LIRAssembler_aarch64.cpp

49 lines changed; 11 ins; 32 del; 6 mod; 3149 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/aarch64/c1_MacroAssembler_aarch64.cpp

45 lines changed; 22 ins; 13 del; 10 mod; 348 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/aarch64/c1_MacroAssembler_aarch64.hpp

1 lines changed; 0 ins; 0 del; 1 mod; 114 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/aarch64/c2_CodeStubs_aarch64.cpp

11 lines changed; 11 ins; 0 del; 0 mod; 94 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/aarch64/c2_MacroAssembler_aarch64.cpp

319 lines changed; 288 ins; 22 del; 9 mod; 2203 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/aarch64/c2_MacroAssembler_aarch64.hpp

7 lines changed; 5 ins; 1 del; 1 mod; 177 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/aarch64/interp_masm_aarch64.cpp

18 lines changed; 0 ins; 17 del; 1 mod; 1859 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp

169 lines changed; 99 ins; 28 del; 42 mod; 6224 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/aarch64/macroAssembler_aarch64.hpp

5 lines changed; 2 ins; 0 del; 3 mod; 1620 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp

4 lines changed; 0 ins; 3 del; 1 mod; 3103 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/aarch64/templateTable_aarch64.cpp

21 lines changed; 14 ins; 0 del; 7 mod; 3976 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/aarch64/vm_version_aarch64.hpp

2 lines changed; 1 ins; 0 del; 1 mod; 190 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/arm/c1_CodeStubs_arm.cpp

4 lines changed; 4 ins; 0 del; 0 mod; 427 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/arm/c1_LIRAssembler_arm.cpp

1 lines changed; 0 ins; 0 del; 1 mod; 2874 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/ppc/assembler_ppc.hpp

66 lines changed; 0 ins; 66 del; 0 mod; 2500 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/ppc/assembler_ppc.inline.hpp

21 lines changed; 0 ins; 21 del; 0 mod; 1159 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/ppc/c1_CodeStubs_ppc.cpp

4 lines changed; 4 ins; 0 del; 0 mod; 486 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/ppc/c1_LIRAssembler_ppc.cpp

1 lines changed; 0 ins; 0 del; 1 mod; 3252 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/ppc/c1_MacroAssembler_ppc.cpp

17 lines changed; 10 ins; 3 del; 4 mod; 420 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/ppc/c1_MacroAssembler_ppc.hpp

1 lines changed; 0 ins; 0 del; 1 mod; 92 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/ppc/c2_MacroAssembler_ppc.cpp

11 lines changed; 11 ins; 0 del; 0 mod; 609 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/ppc/c2_MacroAssembler_ppc.hpp

6 lines changed; 6 ins; 0 del; 0 mod; 68 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/ppc/globalDefinitions_ppc.hpp

7 lines changed; 0 ins; 7 del; 0 mod; 48 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/ppc/globals_ppc.hpp

44 lines changed; 0 ins; 43 del; 1 mod; 114 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/ppc/interp_masm_ppc_64.cpp

22 lines changed; 2 ins; 19 del; 1 mod; 2404 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/ppc/macroAssembler_ppc.cpp

912 lines changed; 337 ins; 541 del; 34 mod; 3468 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/ppc/macroAssembler_ppc.hpp

40 lines changed; 5 ins; 30 del; 5 mod; 895 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/ppc/ppc.ad

49 lines changed; 19 ins; 25 del; 5 mod; 14837 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/ppc/sharedRuntime_ppc.cpp

31 lines changed; 9 ins; 19 del; 3 mod; 3699 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/ppc/vm_version_ppc.cpp

86 lines changed; 0 ins; 85 del; 1 mod; 618 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/ppc/vm_version_ppc.hpp

4 lines changed; 1 ins; 3 del; 0 mod; 129 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/riscv/c1_CodeStubs_riscv.cpp

5 lines changed; 5 ins; 0 del; 0 mod; 341 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/riscv/c1_LIRAssembler_riscv.cpp

1 lines changed; 0 ins; 0 del; 1 mod; 2272 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/riscv/c1_MacroAssembler_riscv.cpp

18 lines changed; 9 ins; 6 del; 3 mod; 440 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/riscv/c1_MacroAssembler_riscv.hpp

1 lines changed; 0 ins; 0 del; 1 mod; 121 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/riscv/c2_MacroAssembler_riscv.cpp

406 lines changed; 309 ins; 50 del; 47 mod; 2034 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/riscv/c2_MacroAssembler_riscv.hpp

4 lines changed; 3 ins; 1 del; 0 mod; 252 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/riscv/interp_masm_riscv.cpp

19 lines changed; 0 ins; 19 del; 0 mod; 1998 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/riscv/macroAssembler_riscv.cpp

131 lines changed; 61 ins; 34 del; 36 mod; 4696 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/riscv/macroAssembler_riscv.hpp

2 lines changed; 0 ins; 0 del; 2 mod; 1471 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/riscv/riscv.ad

36 lines changed; 34 ins; 0 del; 2 mod; 10369 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/riscv/sharedRuntime_riscv.cpp

5 lines changed; 0 ins; 4 del; 1 mod; 3002 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/riscv/vm_version_riscv.hpp

2 lines changed; 2 ins; 0 del; 0 mod; 209 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/s390/c1_CodeStubs_s390.cpp

5 lines changed; 5 ins; 0 del; 0 mod; 449 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/s390/c1_LIRAssembler_s390.cpp

1 lines changed; 0 ins; 0 del; 1 mod; 3099 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/s390/c1_MacroAssembler_s390.cpp

5 lines changed; 0 ins; 0 del; 5 mod; 381 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/s390/c1_MacroAssembler_s390.hpp

1 lines changed; 0 ins; 0 del; 1 mod; 101 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/c1_CodeStubs_x86.cpp

12 lines changed; 12 ins; 0 del; 0 mod; 532 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/c1_LIRAssembler_x86.cpp

35 lines changed; 17 ins; 12 del; 6 mod; 4083 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/c1_MacroAssembler_x86.cpp

44 lines changed; 28 ins; 5 del; 11 mod; 387 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/c1_MacroAssembler_x86.hpp

1 lines changed; 0 ins; 0 del; 1 mod; 129 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/c2_CodeStubs_x86.cpp

80 lines changed; 65 ins; 4 del; 11 mod; 79 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp

303 lines changed; 271 ins; 27 del; 5 mod; 6122 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/c2_MacroAssembler_x86.hpp

6 lines changed; 6 ins; 0 del; 0 mod; 495 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/interp_masm_x86.cpp

17 lines changed; 2 ins; 11 del; 4 mod; 2114 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/macroAssembler_x86.cpp

163 lines changed; 113 ins; 8 del; 42 mod; 9811 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/macroAssembler_x86.hpp

14 lines changed; 11 ins; 0 del; 3 mod; 2045 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/sharedRuntime_x86.cpp

18 lines changed; 13 ins; 0 del; 5 mod; 112 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/sharedRuntime_x86_32.cpp

6 lines changed; 0 ins; 4 del; 2 mod; 2845 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/sharedRuntime_x86_64.cpp

6 lines changed; 0 ins; 4 del; 2 mod; 3710 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/templateTable_x86.cpp

27 lines changed; 18 ins; 0 del; 9 mod; 4474 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/vm_version_x86.hpp

5 lines changed; 4 ins; 0 del; 1 mod; 870 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/x86_32.ad

28 lines changed; 27 ins; 0 del; 1 mod; 13977 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/x86_64.ad

43 lines changed; 42 ins; 0 del; 1 mod; 13815 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/c1/c1_CodeStubs.hpp

18 lines changed; 18 ins; 0 del; 0 mod; 584 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/c1/c1_LIR.cpp

7 lines changed; 7 ins; 0 del; 0 mod; 2123 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/c1/c1_LIR.hpp

5 lines changed; 3 ins; 0 del; 2 mod; 2585 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/c1/c1_LIRGenerator.cpp

2 lines changed; 1 ins; 0 del; 1 mod; 3573 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/cds/archiveBuilder.cpp

7 lines changed; 7 ins; 0 del; 0 mod; 1191 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/cds/archiveHeapWriter.cpp

23 lines changed; 17 ins; 1 del; 5 mod; 541 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/cds/filemap.cpp

10 lines changed; 10 ins; 0 del; 0 mod; 2497 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/cds/filemap.hpp

2 lines changed; 2 ins; 0 del; 0 mod; 570 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/ci/ciKlass.cpp

20 lines changed; 20 ins; 0 del; 0 mod; 251 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/ci/ciKlass.hpp

3 lines changed; 3 ins; 0 del; 0 mod; 134 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1CollectedHeap.cpp

3 lines changed; 3 ins; 0 del; 0 mod; 3129 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1FullCollector.cpp

27 lines changed; 23 ins; 0 del; 4 mod; 523 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1FullCollector.hpp

4 lines changed; 4 ins; 0 del; 0 mod; 175 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1FullGCAdjustTask.cpp

32 lines changed; 21 ins; 1 del; 10 mod; 99 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1FullGCAdjustTask.hpp

3 lines changed; 2 ins; 1 del; 0 mod; 46 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1FullGCCompactTask.cpp

34 lines changed; 19 ins; 1 del; 14 mod; 135 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1FullGCCompactTask.hpp

6 lines changed; 6 ins; 0 del; 0 mod; 69 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1FullGCCompactionPoint.cpp

14 lines changed; 9 ins; 0 del; 5 mod; 209 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1FullGCCompactionPoint.hpp

2 lines changed; 2 ins; 0 del; 0 mod; 68 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1FullGCOopClosures.hpp

1 lines changed; 1 ins; 0 del; 0 mod; 97 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1FullGCOopClosures.inline.hpp

10 lines changed; 4 ins; 0 del; 6 mod; 83 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1FullGCPrepareTask.cpp

12 lines changed; 7 ins; 0 del; 5 mod; 116 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1FullGCPrepareTask.hpp

2 lines changed; 2 ins; 0 del; 0 mod; 115 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1FullGCPrepareTask.inline.hpp

6 lines changed; 2 ins; 0 del; 4 mod; 116 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1OopClosures.inline.hpp

1 lines changed; 0 ins; 0 del; 1 mod; 274 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1ParScanThreadState.cpp

17 lines changed; 6 ins; 0 del; 11 mod; 706 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1ParScanThreadState.hpp

2 lines changed; 0 ins; 0 del; 2 mod; 259 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/parallel/mutableSpace.cpp

28 lines changed; 25 ins; 0 del; 3 mod; 263 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/parallel/mutableSpace.hpp

3 lines changed; 3 ins; 0 del; 0 mod; 162 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/parallel/psOldGen.cpp

3 lines changed; 2 ins; 0 del; 1 mod; 413 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/parallel/psPromotionManager.cpp

2 lines changed; 0 ins; 0 del; 2 mod; 357 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/parallel/psPromotionManager.hpp

1 lines changed; 0 ins; 0 del; 1 mod; 182 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/parallel/psPromotionManager.inline.hpp

31 lines changed; 21 ins; 0 del; 10 mod; 345 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/serial/defNewGeneration.cpp

3 lines changed; 0 ins; 1 del; 2 mod; 1157 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/serial/genMarkSweep.cpp

26 lines changed; 17 ins; 0 del; 9 mod; 260 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/serial/markSweep.cpp

23 lines changed; 13 ins; 4 del; 6 mod; 238 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/serial/markSweep.hpp

12 lines changed; 7 ins; 4 del; 1 mod; 191 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/serial/markSweep.inline.hpp

16 lines changed; 8 ins; 0 del; 8 mod; 57 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/collectedHeap.cpp

12 lines changed; 9 ins; 0 del; 3 mod; 633 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/collectedHeap.hpp

1 lines changed; 0 ins; 0 del; 1 mod; 553 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/gc_globals.hpp

6 lines changed; 4 ins; 0 del; 2 mod; 696 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/genCollectedHeap.cpp

3 lines changed; 3 ins; 0 del; 0 mod; 1150 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/memAllocator.cpp

11 lines changed; 7 ins; 2 del; 2 mod; 417 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/preservedMarks.cpp

13 lines changed; 10 ins; 0 del; 3 mod; 166 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/preservedMarks.hpp

3 lines changed; 3 ins; 0 del; 0 mod; 127 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/preservedMarks.inline.hpp

1 lines changed; 1 ins; 0 del; 0 mod; 63 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/gc/shared/slidingForwarding.cpp

123 lines changed; 123 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/gc/shared/slidingForwarding.hpp

181 lines changed; 181 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/gc/shared/slidingForwarding.inline.hpp

171 lines changed; 171 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/space.cpp

39 lines changed; 28 ins; 0 del; 11 mod; 686 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/space.hpp

14 lines changed; 12 ins; 0 del; 2 mod; 531 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahAsserts.cpp

2 lines changed; 0 ins; 0 del; 2 mod; 425 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahFullGC.cpp

88 lines changed; 70 ins; 0 del; 18 mod; 1054 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahFullGC.hpp

5 lines changed; 5 ins; 0 del; 0 mod; 90 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp

3 lines changed; 3 ins; 0 del; 0 mod; 2287 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahHeap.inline.hpp

22 lines changed; 17 ins; 3 del; 2 mod; 564 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp

9 lines changed; 1 ins; 0 del; 8 mod; 966 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/x/c2/xBarrierSetC2.cpp

1 lines changed; 0 ins; 0 del; 1 mod; 582 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/x/xObjArrayAllocator.cpp

17 lines changed; 14 ins; 0 del; 3 mod; 90 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/c2/zBarrierSetC2.cpp

1 lines changed; 0 ins; 0 del; 1 mod; 982 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zObjArrayAllocator.cpp

22 lines changed; 18 ins; 0 del; 4 mod; 137 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zRelocate.cpp

3 lines changed; 2 ins; 1 del; 0 mod; 1336 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/interpreter/zero/bytecodeInterpreter.cpp

7 lines changed; 3 ins; 0 del; 4 mod; 3431 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jfr/leakprofiler/chains/objectSampleMarker.hpp

1 lines changed; 0 ins; 0 del; 1 mod; 77 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jvmci/jvmciCompilerToVM.cpp

1 lines changed; 0 ins; 0 del; 1 mod; 3211 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jvmci/jvmciCompilerToVMInit.cpp

1 lines changed; 0 ins; 1 del; 0 mod; 472 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jvmci/jvmci_globals.cpp

1 lines changed; 0 ins; 1 del; 0 mod; 231 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jvmci/jvmci_globals.hpp

3 lines changed; 0 ins; 3 del; 0 mod; 197 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jvmci/vmStructs_jvmci.cpp

10 lines changed; 10 ins; 0 del; 0 mod; 1044 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/universe.cpp

7 lines changed; 5 ins; 0 del; 2 mod; 1300 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/arrayOop.hpp

65 lines changed; 30 ins; 26 del; 9 mod; 99 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/instanceOop.hpp

10 lines changed; 3 ins; 3 del; 4 mod; 41 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/klass.cpp

15 lines changed; 15 ins; 0 del; 0 mod; 957 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/klass.hpp

9 lines changed; 9 ins; 0 del; 0 mod; 731 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/klass.inline.hpp

5 lines changed; 5 ins; 0 del; 0 mod; 75 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/markWord.hpp

68 lines changed; 59 ins; 0 del; 9 mod; 266 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/oops/markWord.inline.hpp

70 lines changed; 70 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/objArrayKlass.cpp

2 lines changed; 1 ins; 0 del; 1 mod; 511 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/objArrayKlass.inline.hpp

2 lines changed; 1 ins; 0 del; 1 mod; 120 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/objArrayOop.hpp

32 lines changed; 0 ins; 27 del; 5 mod; 61 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/oop.cpp

5 lines changed; 3 ins; 0 del; 2 mod; 241 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/oop.hpp

57 lines changed; 55 ins; 0 del; 2 mod; 331 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/oop.inline.hpp

180 lines changed; 160 ins; 5 del; 15 mod; 373 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/typeArrayKlass.cpp

2 lines changed; 1 ins; 0 del; 1 mod; 375 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/typeArrayKlass.inline.hpp

2 lines changed; 1 ins; 0 del; 1 mod; 57 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/c2_CodeStubs.hpp

32 lines changed; 30 ins; 0 del; 2 mod; 162 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/callnode.cpp

8 lines changed; 6 ins; 0 del; 2 mod; 2239 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/compile.cpp

4 lines changed; 4 ins; 0 del; 0 mod; 5246 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/library_call.cpp

15 lines changed; 8 ins; 0 del; 7 mod; 8157 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/macro.cpp

3 lines changed; 2 ins; 0 del; 1 mod; 2624 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/memnode.cpp

15 lines changed; 14 ins; 0 del; 1 mod; 5018 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/runtime.cpp

9 lines changed; 4 ins; 1 del; 4 mod; 1818 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/type.cpp

3 lines changed; 1 ins; 1 del; 1 mod; 6688 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/unsafe.cpp

1 lines changed; 0 ins; 0 del; 1 mod; 933 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/whitebox.cpp

11 lines changed; 11 ins; 0 del; 0 mod; 2870 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/abstract_vm_version.hpp

4 lines changed; 3 ins; 0 del; 1 mod; 211 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/arguments.cpp

37 lines changed; 29 ins; 0 del; 8 mod; 4217 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/basicLock.cpp

21 lines changed; 7 ins; 0 del; 14 mod; 70 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/deoptimization.cpp

21 lines changed; 15 ins; 0 del; 6 mod; 2923 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/globals.hpp

4 lines changed; 4 ins; 0 del; 0 mod; 1993 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/lockStack.cpp

80 lines changed; 79 ins; 0 del; 1 mod; 90 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/lockStack.hpp

36 lines changed; 30 ins; 0 del; 6 mod; 93 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/lockStack.inline.hpp

129 lines changed; 104 ins; 10 del; 15 mod; 96 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/objectMonitor.cpp

66 lines changed; 65 ins; 0 del; 1 mod; 2243 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/objectMonitor.hpp

4 lines changed; 3 ins; 0 del; 1 mod; 367 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/objectMonitor.inline.hpp

7 lines changed; 6 ins; 0 del; 1 mod; 176 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/sharedRuntime.cpp

17 lines changed; 8 ins; 0 del; 9 mod; 3406 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/synchronizer.cpp

236 lines changed; 140 ins; 43 del; 53 mod; 1883 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/synchronizer.hpp

21 lines changed; 19 ins; 0 del; 2 mod; 253 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/vmStructs.cpp

5 lines changed; 5 ins; 0 del; 0 mod; 3131 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/utilities/fastHash.hpp

97 lines changed; 97 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/utilities/globalDefinitions.hpp

2 lines changed; 1 ins; 0 del; 1 mod; 1367 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/debugger/DebuggerBase.java

12 lines changed; 11 ins; 0 del; 1 mod; 524 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/memory/Universe.java

7 lines changed; 0 ins; 7 del; 0 mod; 117 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/Array.java

37 lines changed; 20 ins; 13 del; 4 mod; 89 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/Instance.java

3 lines changed; 2 ins; 0 del; 1 mod; 81 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/Mark.java

27 lines changed; 26 ins; 0 del; 1 mod; 200 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/Oop.java

32 lines changed; 23 ins; 0 del; 9 mod; 206 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/VM.java

10 lines changed; 10 ins; 0 del; 0 mod; 1096 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/utilities/RobustOopDeterminator.java

26 lines changed; 1 ins; 24 del; 1 mod; 30 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/gtest/gc/shared/test_preservedMarks.cpp

3 lines changed; 3 ins; 0 del; 0 mod; 88 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/gtest/gc/shared/test_slidingForwarding.cpp

124 lines changed; 124 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/gtest/oops/test_arrayOop.cpp

65 lines changed; 55 ins; 8 del; 2 mod; 71 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/gtest/oops/test_objArrayOop.cpp

69 lines changed; 69 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/gtest/oops/test_typeArrayOop.cpp

5 lines changed; 4 ins; 0 del; 1 mod; 64 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/gtest/runtime/test_lockStack.cpp

427 lines changed; 427 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/ProblemList-lilliput.txt

40 lines changed; 40 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/ProblemList.txt

4 lines changed; 0 ins; 0 del; 4 mod; 171 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/TEST.groups

2 lines changed; 1 ins; 0 del; 1 mod; 764 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/c2/irTests/TestVectorizationMismatchedAccess.java

10 lines changed; 5 ins; 0 del; 5 mod; 334 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/c2/irTests/TestVectorizationNotRun.java

2 lines changed; 1 ins; 0 del; 1 mod; 68 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/compiler/escapeAnalysis/Test8329757.java

72 lines changed; 72 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/compiler/escapeAnalysis/TestNestedRelockAtDeopt.java

146 lines changed; 146 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/lib/ir_framework/TestFramework.java

2 lines changed; 1 ins; 0 del; 1 mod; 771 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/loopopts/superword/TestIndependentPacksWithCyclicDependency.java

2 lines changed; 1 ins; 0 del; 1 mod; 478 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/rtm/cli/RTMGenericCommandLineOptionTest.java

3 lines changed; 0 ins; 2 del; 1 mod; 211 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/rtm/cli/TestUseRTMLockingOptionOnUnsupportedCPU.java

28 lines changed; 0 ins; 20 del; 8 mod; 70 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/rtm/locking/TestRTMSpinLoopCount.java

5 lines changed; 0 ins; 4 del; 1 mod; 116 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/TestAllocHumongousFragment.java

12 lines changed; 12 ins; 0 del; 0 mod; 217 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/g1/plab/TestPLABPromotion.java

6 lines changed; 4 ins; 0 del; 2 mod; 364 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/stress/systemgc/TestSystemGCWithG1.java

12 lines changed; 11 ins; 0 del; 1 mod; 39 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/stress/systemgc/TestSystemGCWithSerial.java

32 lines changed; 31 ins; 0 del; 1 mod; 39 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/stress/systemgc/TestSystemGCWithShenandoah.java

16 lines changed; 16 ins; 0 del; 0 mod; 61 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/gtest/ArrayTests.java

56 lines changed; 56 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/gtest/LockStackGtests.java

32 lines changed; 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/gtest/ObjArrayTests.java

85 lines changed; 85 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/FieldLayout/BaseOffsets.java

130 lines changed; 130 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/FieldLayout/OldLayoutCheck.java

24 lines changed; 16 ins; 0 del; 8 mod; 71 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/cds/CdsDifferentCompactObjectHeaders.java

66 lines changed; 66 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/cds/appcds/TestZGCWithCDS.java

15 lines changed; 15 ins; 0 del; 0 mod; 160 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/TestAutoCreateSharedArchiveNoDefaultArchive.java

1 lines changed; 1 ins; 0 del; 0 mod; 157 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/lockStack/TestLockStackCapacity.java

108 lines changed; 108 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/locking/TestRecursiveMonitorChurn.java

95 lines changed; 95 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/whitebox/TestWBDeflateIdleMonitors.java

4 lines changed; 0 ins; 1 del; 3 mod; 88 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/com/sun/jdi/EATests.java

157 lines changed; 157 ins; 0 del; 0 mod; 3177 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/instrument/GetObjectSizeIntrinsicsTest.java

25 lines changed; 14 ins; 0 del; 11 mod; 462 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jlink/plugins/CDSPluginTest.java

11 lines changed; 8 ins; 0 del; 3 mod; 83 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/lib/jdk/test/whitebox/WhiteBox.java

5 lines changed; 4 ins; 0 del; 1 mod; 763 unchg

This code review page was prepared using webrev version 8aab2a590929de7d98c8bd1e8c6cf12e40cb6433